[tor-bugs] Re: #1564 [Tor-Tor server]: Reported dirreq-v3-stats are 0.00%

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#1564: Reported dirreq-v3-stats are 0.00%
----------------------------+-----------------------------------------------
 Reporter:  karsten         |       Owner:  karsten                           
     Type:  defect          |      Status:  new                               
 Priority:  normal          |   Milestone:  Calculate directory request shares
Component:  Tor-Tor server  |     Version:                                    
 Keywords:                  |      Parent:                                    
----------------------------+-----------------------------------------------

Comment(by karsten):

 Let me recap what happens here:

  * router_get_my_share_of_directory_requests() calls
    * router_pick_directory_server() which calls
      * router_pick_directory_server_impl() which calls
        * routerstatus_sl_choose_by_bandwidth() which calls
          * smartlist_choose_by_bandwidth_weights() first and if that fails
          * smartlist_choose_by_bandwidth(), where the latter sets
            * sl_last_weighted_bw_of_me and
            * sl_last_total_weighted_bw that we use to calculate shares.

 Mike: Your suggestion is to have smartlist_choose_by_bandwidth_weights()
 set the two global variables? Sounds fine to me. Does the attached
 *untested* patch do what you have in mind?

 What alternatives are there? We need a fix very soon, like today. And this
 whole dirreq-share code needs to stay in Tor for a couple more months only
 until we have a good way to calculate shares from other information and
 are confident that the new approach gives us good numbers. Let's not move
 too much code around to make this happen.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1564#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online