[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22183 [- Select a component]: --disable-transparent option is gone without the ChangeLog record

#22183: --disable-transparent option is gone without the ChangeLog record
----------------------------------+---------------------
 Reporter:  yurivict271           |          Owner:
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:
Component:  - Select a component  |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:                        |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+---------------------

Comment (by yurivict271):

 The de-facto new way of enabling of USE_TRANSPARENT is checking for both
 net/if.h and net/pfvar.h. This makes it always enabled even when not
 needed.

 FYI, the FreeBSD port has a special option TRANSPARENT, off by default,
 that is rendered broken now.

 Since transparent proxy is needed only by a small fraction of users, I
 suggest the behavior should be:
 1. there have to be --enable-transparent/--disable-transparent options
 2. --disable-transparent should be the default
 3. the above-mentioned headers should be checked only when the option is
 enabled

 Also, checking net/pfvar.h is questionable since transparent proxy can be
 used with other than pf firewalls.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22183#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs