Re: [or-cvs] petty cleanups

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Tue, Apr 25, 2006 at 03:00:06AM -0400, arma@xxxxxxxx wrote:
 [...]
> -  if (!desc_routerinfo || !desc_clean_since) {
> +  if (!desc_routerinfo || !desc_clean_since)
>      if (router_rebuild_descriptor(!desc_routerinfo))
>        return NULL;
> -  }

Actually, I like the braces in these cases.  It means that if we add
elses later, no further braces are needed, as opposed to 
  if (A)
   if (B)
     x;
  else (C)
     y;

which is the canonical "who knows what that means anyway" parse.

No need to shift back in this case; just an IMO. 

yrs,
-- 
Nick Mathewson