[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-bug: [Bug 698851] Re: libgeda calls exit()



A commit was made which affects this bug
git master commit 0f978cc519016ac1cbb56c772107e1f23c98c831
http://git.gpleda.org/?p=gaf.git;a=commit;h=0f978cc519016ac1cbb56c772107e1f23c98c831

commit 0f978cc519016ac1cbb56c772107e1f23c98c831
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    Remove exit_if_null().
    
    Replace with g_return_if_fail(), g_return_val_if_fail(), etc.  We
    shouldn't exit() from a shared library anyway.
    
    Also, this patch makes gschem *not* crash in a bunch of places where
    it doesn't really make sense to just give up.
    
    Affects-bug: lp-698851

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698851

Title:
  libgeda calls exit()

Status in GPL Electronic Design Automation tools:
  Fix Committed

Bug description:
  Hello,

    I am working on the Debian package for geda, when I ran lintian on
  the package, I got this:

   libgeda38: shlib-calls-exit usr/lib/libgeda.so.38.0.0                                                                                                      
                                                                                                                                                              
      The listed shared library calls the C library exit() or _exit()                                                                                         
      functions.                                                                                                                                              
                                                                                                                                                              
      In the case of an error, the library should instead return an                                                                                           
      appropriate error code to the calling program which can then determine                                                                                  
      how to handle the error, including performing any required clean-up.

  I am not sure if this is a real issue or not, since libgeda is most
  probably only used by the tools in geda. So I though of bringing this
  up here for you to decide.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/698851/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug