Re: gEDA-bug: [Bug 698741] Re: Problematic attribute place holder values

[clifcox <698741@xxxxxxxxxxxxxxxxxx>]

Hi Peter,

Wow long time no hear. I thought you were mad at me for getting 
distracted with other things. ;-)

The second patch labeled "New patch 
<https://bugs.launchpad.net/geda/+bug/698741/+attachment/1797265/+files/0001-Updated-the-problematic-name-attribute-in-some-symbo.patch>" 
is the one you want. The first one is a bit over zealous. There didn't 
seem to be an option to delete it.

Also I guess you need to up date the test file for the suite with the 
new version in my post from 2011-01-30.

Lets see... don't apply the patch from 2011-01-31 but do apply this one: 
"Minor Changes to cascade output.net so it will pass the test suite. 
<https://bugs.launchpad.net/geda/+bug/698741/+attachment/1824166/+files/0001-Minor-Changes-to-cascade-output.net-so-it-will-pass.patch>"

I see I had an unanswered question; why would you ever see "unknown" 
written out as if it were
an actual attribute? If that is an oversight we can remove them from the 
output and update the test suite accordingly. Though I just might not 
remember the reason it's like this. ;-)

     Ciao,
     Clif

Peter TB Brett wrote:
> Hi Clif,
>
> I'm just revisiting this bug in the hope of being able to commit your
> patches and close it. :-)
>
> I'm slightly confused -- which patches do I need to commit, and it what
> order?
>
> Thanks!
>
>

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698741

Title:
  Problematic attribute place holder values

Status in GPL Electronic Design Automation tools:
  Triaged

Bug description:
  In some gnetlist backends the name=? attributes cause problems because they look like
  valid attribute values. eg file=? may be mistaken for a valid filepath, and value=? for 
  an actual value. Changing them to name=unknown is one way to solve this problem in the
  interim. It's now safe to remove the special checks for these "?" like the one in spice-sdb.
  This patch updates these problematic name=? attributes in some symbols to name=unknown,
  and removes FIXME code snipit that checked for the ? value in spice-sdb.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/698741/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug