[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-bug: [Bug 698741] Re: Problematic attribute place holder values



On Friday 10 June 2011 16:38:33 you wrote:

> I see I had an unanswered question; why would you ever see "unknown"
> written out as if it were an actual attribute? If that is an oversight
> we can remove them from the output and update the test suite
> accordingly. Though I just might not remember the reason it's like
> this. ;-)

If a gnetlist backend requests an attribute that doesn't exist, gnetlist 
currently reports that the attribute's value is, literally, "unknown".

So there's currently no distinction between having a value "unknown" and 
the attribute not even existing.

See gnetlist:get-package-attribute (which you wrote IIRC), 
g_get_attribute_by_pinseq(), and g_get_attribute_by_pinnumber().

This is IMHO a bug, and it would be better for gnetlist to report #f as 
the value of an attribute that doesn't exist.

Cheers,

                            Peter

-- 
Peter Brett <peter@xxxxxxxxxxxxx>
Remote Sensing Research Group
Surrey Space Centre

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/698741

Title:
  Problematic attribute place holder values

Status in GPL Electronic Design Automation tools:
  Triaged

Bug description:
  In some gnetlist backends the name=? attributes cause problems because they look like
  valid attribute values. eg file=? may be mistaken for a valid filepath, and value=? for 
  an actual value. Changing them to name=unknown is one way to solve this problem in the
  interim. It's now safe to remove the special checks for these "?" like the one in spice-sdb.
  This patch updates these problematic name=? attributes in some symbols to name=unknown,
  and removes FIXME code snipit that checked for the ? value in spice-sdb.

To manage notifications about this bug go to:
https://bugs.launchpad.net/geda/+bug/698741/+subscriptions


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug