gEDA-bug: [Bug 726828] Re: xgsch2pcb breaks with spaces in filenames

[Peter Clifton <pcjc2@xxxxxxxxx>]

Looks good to me.

I've not had time to review line-by-line, but I skimmed the patch series
and it looks excellent. Unfortunately, I won't have time to test and
commit just now - as I'm supposed to be working on something else. (Just
checking my email at the moment).

It did occur to me (although I never tested it), that the spawn function
currently in use with gsch2pcb actually passes through a shell expansion
phase, so "" and \" quoting "might" have already worked - but that is
very subtle and not at all obvious.

I think your patch series is superior in every way to what we had.

I REALLY want to see you get commit access so you can push changes
directly (even if you still want to get them reviewed first). Please
email me off list and we can see about making that happen.

Best wishes,

-- 
You received this bug notification because you are a member of gEDA Bug
Team, which is subscribed to gEDA.
https://bugs.launchpad.net/bugs/726828

Title:
  xgsch2pcb breaks with spaces in filenames

Status in GPL Electronic Design Automation tools:
  In Progress

Bug description:
  When creating a project (in this case from a template), with a space
  in the project name, the template copied schematics to names which had
  a space in them. The resulting .gsch2pcb file was not suitably quoted,
  and the file-names were broken at the space.


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug