gEDA-bug: [ geda-Patches-3117075 ] spice-sdb -- Several fixes / Cleanups

["SourceForge.net" <noreply@xxxxxxxxxxxxxxx>]

Patches item #3117075, was opened at 2010-11-23 15:54
Message generated for change (Tracker Item Submitted) made by clifcox
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=3117075&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gnetlist
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Clif Cox (clifcox)
Assigned to: Nobody/Anonymous (nobody)
Summary: spice-sdb -- Several fixes / Cleanups

Initial Comment:
Here is the patch set that i mentioned recently on geda-users along with my notes:

There is a bug related to the file attribute that seems to cause the variable "type" to be bound globally when a file is read in. This obscures another bug in write-ic and write-subcircuit where type is referenced but not localized. The value that the global type ended up with was something like "" and no one noticed when some symbols didn't have type set. In the process of adding a local copy I followed the advice in the comments that the two routines should be combined since they were virtual clones, so everything calls write-ic now.

There is another bug where get-package-attribute sometimes returns a "?" instead of "unknown" which I posted a fix for in patch # 3114991. One hunk removes the code snippet that dealt with this bug.

I did a general clean up to write-net-names-on-component that may make it more flexible. The code is about the same length when the debug statements are removed, though I had to add a couple of small utility routines.

I ran make tests and it passes.

    Ciao,
    Clif

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818428&aid=3117075&group_id=161080


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug