gEDA-bug: [ geda-Bugs-3074264 ] gattrib "add column" menu item moves data incorrectly

["SourceForge.net" <noreply@xxxxxxxxxxxxxxx>]

Bugs item #3074264, was opened at 2010-09-23 14:12
Message generated for change (Tracker Item Submitted) made by armena
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=3074264&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gattrib
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Andrew Armenia (armena)
Assigned to: Nobody/Anonymous (nobody)
Summary: gattrib "add column" menu item moves data incorrectly

Initial Comment:
When using gattrib (obtained earlier today from git://git.gpleda.org/gaf.git) and selecting the "Add new attrib column" entry from the "Edit" menu, a new column is added, as expected. gattrib also helpfully sorts the column headings. However, the data in the table below does not get moved to match the new column headings! 

I have been reading through the code but I have not yet figured out the mapping between the table columns and the spreadsheet columns, although it doesn't look as if s_toplevel_add_new_attrib goes out of its way to fix things up after sorting the column headers. Indeed, I've worked around the issue in the interim by commenting out the call to s_string_list_sort_master_comp_attrib_list( ) in s_toplevel_add_new_attrib( ). It doesn't fix the underlying problem, but does allow me to get work done.

For anyone thinking about writing a real patch, I did do a small bit of additional investigation. There was a patch around 2006 which changed s_toplevel_add_new_attrib( ) to resize the table instead of reconstructing it from scratch. git commit 9d0f3a29, I think ("fixed bug in which adding a new attrib column would munge the visibility of existing attributes"). That introduced s_table_resize and possibly this bug. But I could easily be wrong on that.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=3074264&group_id=161080


_______________________________________________
geda-bug mailing list
geda-bug@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-bug