gEDA-cvs: gaf.git: branch: master updated (1.5.2-20090328-209-g15e761e)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  15e761e3d09923bb3cdc850b93f653850071cc35 (commit)
      from  e5ae12ec1091bd6e3c4067e395714efd3934b0c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gattrib/lib/gattrib-menus.xml |    2 +-
 gattrib/src/x_window.c        |    4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)


=================
 Commit Messages
=================

commit 15e761e3d09923bb3cdc850b93f653850071cc35
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    gattrib: Remove menu entry for unimplemented "File->Open" feature
    
    Popping up a dialog for unimplemented features stops the user being
    able to identify what parts of the program are supposed to work.
    
    Due to internal data-structures not being cleared out, opening new
    files is not a trivial feature to implement cleanly.
    
    Remove the non-working menu option for now.
    
    Users must select the files they wish to work with as command line
    arguments, or in the file-chooser dialog offered when the program
    starts.

:100644 100644 d40cf8d... 0aa1174... M	gattrib/lib/gattrib-menus.xml
:100644 100644 4bf3cfe... 5e4cc4f... M	gattrib/src/x_window.c

=========
 Changes
=========

commit 15e761e3d09923bb3cdc850b93f653850071cc35
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    gattrib: Remove menu entry for unimplemented "File->Open" feature
    
    Popping up a dialog for unimplemented features stops the user being
    able to identify what parts of the program are supposed to work.
    
    Due to internal data-structures not being cleared out, opening new
    files is not a trivial feature to implement cleanly.
    
    Remove the non-working menu option for now.
    
    Users must select the files they wish to work with as command line
    arguments, or in the file-chooser dialog offered when the program
    starts.

diff --git a/gattrib/lib/gattrib-menus.xml b/gattrib/lib/gattrib-menus.xml
index d40cf8d..0aa1174 100644
--- a/gattrib/lib/gattrib-menus.xml
+++ b/gattrib/lib/gattrib-menus.xml
@@ -1,7 +1,7 @@
 <ui>
   <menubar>
     <menu action="file">
-      <menuitem action="file-open" />
+      <!-- <menuitem action="file-open" / > -->
       <menuitem action="file-save" />
       <menuitem action="file-export-csv" />
       <separator/>
diff --git a/gattrib/src/x_window.c b/gattrib/src/x_window.c
index 4bf3cfe..5e4cc4f 100644
--- a/gattrib/src/x_window.c
+++ b/gattrib/src/x_window.c
@@ -133,6 +133,7 @@ x_window_init()
  * -# close the current project and reinitialize structures
  * -# load the new project
  */
+#ifdef UNIMPLEMENTED_FEATURES
 static void
 menu_file_open()
 {
@@ -149,6 +150,7 @@ menu_file_open()
   g_slist_free(file_list);
 #endif
 }
+#endif
 
 /*!
  * \brief File->Save menu item
@@ -223,7 +225,7 @@ static const GtkActionEntry actions[] = {
   /* name, stock-id, label, accelerator, tooltip, callback function */
   /* File menu */
   { "file", NULL, "_File"},
-  { "file-open", GTK_STOCK_OPEN, "Open", "<Control>O", "", menu_file_open},
+  /* { "file-open", GTK_STOCK_OPEN, "Open", "<Control>O", "", menu_file_open}, */
   { "file-save", GTK_STOCK_SAVE, "Save", "<Control>S", "", menu_file_save},
   { "file-export-csv", NULL, "Export CSV", "", "", menu_file_export_csv},
   /* { "file-print", GTK_STOCK_PRINT, "Print", "<Control>P", "", x_dialog_unimplemented_feature}, */




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs