[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: pcb.git: branch: master updated (eebe6b36b19a8c0c8315fd08dbcac36a274170a4)
The branch, master has been updated
via eebe6b36b19a8c0c8315fd08dbcac36a274170a4 (commit)
via 6e87f9ea580493e317a67a61653c904c834b3394 (commit)
via 49df099f5abaea13af5f9cc9d97f28f44fadff44 (commit)
via 8e668cd5f929920d83beed93e00a7aa5d91f6941 (commit)
via 6b9f6896847e2154bc9d328049bbf8fc984cba31 (commit)
via 3659fef988871ec52918f5b946366deccbeaecf8 (commit)
from 478d189ab6460bfb61f12cce4c99fbd1d780eede (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
configure.ac | 2 +-
src/action.c | 14 ++++++++++----
src/file.h | 2 +-
src/hid/gtk/gtkhid-main.c | 9 ++++-----
src/misc.c | 8 ++++++++
src/netlist.c | 9 +++++----
6 files changed, 29 insertions(+), 15 deletions(-)
=================
Commit Messages
=================
commit eebe6b36b19a8c0c8315fd08dbcac36a274170a4
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings about unitialized variables.
Remove some gcc warnings about uninitialized variables. The
logic was such that if the variables weren't ever assigned to somethign
then they also would not have been accessed but by getting rid
of this warning, we increase the chances of paying attention to
other warnings which may indicate real bugs.
:100644 100644 b53bfe2... b675090... M src/misc.c
commit 6e87f9ea580493e317a67a61653c904c834b3394
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Add missing return on an action function which is supposed to return an int.
:100644 100644 1938dea... b53bfe2... M src/misc.c
commit 49df099f5abaea13af5f9cc9d97f28f44fadff44
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings.
Use GPOINTER_TO_INT(), GINT_TO_POINTER() and remove a couple of
unused variables to eliminate some gcc warnings.
:100644 100644 fd399ce... cd30221... M src/hid/gtk/gtkhid-main.c
commit 8e668cd5f929920d83beed93e00a7aa5d91f6941
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
In functions returning non-void, give a return value for returns.
:100644 100644 80e94eb... be81e4e... M src/netlist.c
commit 6b9f6896847e2154bc9d328049bbf8fc984cba31
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Add missing prototype for sort_netlist() which is called in netlist.c.
:100644 100644 fbd238b... 64eba23... M src/file.h
commit 3659fef988871ec52918f5b946366deccbeaecf8
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings.
Add missing headers for fork(), execvp(), wait(). Also remove
a couple of unused variables.
:100644 100644 115bf91... f8001e3... M configure.ac
:100644 100644 cbf3223... f2b04a6... M src/action.c
=========
Changes
=========
commit eebe6b36b19a8c0c8315fd08dbcac36a274170a4
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings about unitialized variables.
Remove some gcc warnings about uninitialized variables. The
logic was such that if the variables weren't ever assigned to somethign
then they also would not have been accessed but by getting rid
of this warning, we increase the chances of paying attention to
other warnings which may indicate real bugs.
diff --git a/src/misc.c b/src/misc.c
index b53bfe2..b675090 100644
--- a/src/misc.c
+++ b/src/misc.c
@@ -2115,6 +2115,12 @@ ElementOrientation (ElementType *e)
int found_pin1 = 0;
int found_pin2 = 0;
+ /* in case we don't find pin 1 or 2, make sure we have initialized these variables */
+ pin1x = 0;
+ pin1y = 0;
+ pin2x = 0;
+ pin2y = 0;
+
PIN_LOOP (e);
{
if (NSTRCMP (pin->Number, "1") == 0)
commit 6e87f9ea580493e317a67a61653c904c834b3394
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Add missing return on an action function which is supposed to return an int.
diff --git a/src/misc.c b/src/misc.c
index 1938dea..b53bfe2 100644
--- a/src/misc.c
+++ b/src/misc.c
@@ -2180,6 +2180,8 @@ ActionListRotations(int argc, char **argv, int x, int y)
printf("%d %s\n", ElementOrientation(element), NAMEONPCB_NAME(element));
}
END_LOOP;
+
+ return 0;
}
HID_Action misc_action_list[] = {
commit 49df099f5abaea13af5f9cc9d97f28f44fadff44
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings.
Use GPOINTER_TO_INT(), GINT_TO_POINTER() and remove a couple of
unused variables to eliminate some gcc warnings.
diff --git a/src/hid/gtk/gtkhid-main.c b/src/hid/gtk/gtkhid-main.c
index fd399ce..cd30221 100644
--- a/src/hid/gtk/gtkhid-main.c
+++ b/src/hid/gtk/gtkhid-main.c
@@ -936,7 +936,7 @@ ghid_attributes_need_rows (int new_max)
GTK_FILL,
0, 0);
g_signal_connect (G_OBJECT (attr_row[attr_max_rows].del), "clicked",
- G_CALLBACK (attributes_delete_callback), (void *)attr_max_rows);
+ G_CALLBACK (attributes_delete_callback), GINT_TO_POINTER (attr_max_rows) );
attr_row[attr_max_rows].w_name = gtk_entry_new ();
gtk_table_attach (GTK_TABLE (attr_table), attr_row[attr_max_rows].w_name,
@@ -1000,9 +1000,8 @@ static void
attributes_delete_callback (GtkWidget *w, void *v)
{
int i, n;
- GtkWidget *wn, *wv;
- n = (int) v;
+ n = GPOINTER_TO_INT (v);
for (i=n; i<attr_num_rows-1; i++)
{
@@ -1093,8 +1092,8 @@ ghid_attributes (char *owner, AttributeListType *attrs)
{
ghid_attributes_need_rows (attr_num_rows + 1); /* also bumps attr_num_rows */
- gtk_entry_set_text (attr_row[attr_num_rows-1].w_name, "");
- gtk_entry_set_text (attr_row[attr_num_rows-1].w_value, "");
+ gtk_entry_set_text (GTK_ENTRY (attr_row[attr_num_rows-1].w_name), "");
+ gtk_entry_set_text (GTK_ENTRY (attr_row[attr_num_rows-1].w_value), "");
ghid_attr_set_table_size ();
}
commit 8e668cd5f929920d83beed93e00a7aa5d91f6941
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
In functions returning non-void, give a return value for returns.
diff --git a/src/netlist.c b/src/netlist.c
index 80e94eb..be81e4e 100644
--- a/src/netlist.c
+++ b/src/netlist.c
@@ -398,12 +398,13 @@ Netlist (int argc, char **argv, int x, int y)
}
else if (strcasecmp (argv[0], "sort") == 0)
{
- return sort_netlist ();
+ sort_netlist ();
+ return 0;
}
else if (strcasecmp (argv[0], "freeze") == 0)
{
netlist_frozen ++;
- return;
+ return 0;
}
else if (strcasecmp (argv[0], "thaw") == 0)
{
@@ -413,14 +414,14 @@ Netlist (int argc, char **argv, int x, int y)
if (netlist_needs_update)
NetlistChanged (0);
}
- return;
+ return 0;
}
else if (strcasecmp (argv[0], "forcethaw") == 0)
{
netlist_frozen = 0;
if (netlist_needs_update)
NetlistChanged (0);
- return;
+ return 0;
}
else
{
commit 6b9f6896847e2154bc9d328049bbf8fc984cba31
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Add missing prototype for sort_netlist() which is called in netlist.c.
diff --git a/src/file.h b/src/file.h
index fbd238b..64eba23 100644
--- a/src/file.h
+++ b/src/file.h
@@ -22,7 +22,6 @@
* Thomas Nau, Schlehenweg 15, 88471 Baustetten, Germany
* Thomas.Nau@xxxxxxxxxxxxx
*
- * RCS: $Id$
*/
/* prototypes for file routines
@@ -48,6 +47,7 @@ int ImportNetlist (char *);
int SaveBufferElements (char *);
void PreLoadElementPCB (void);
void PostLoadElementPCB (void);
+void sort_netlist (void);
/*
* Whenever the pcb file format is modified, this version number
commit 3659fef988871ec52918f5b946366deccbeaecf8
Author: Dan McMahill <dan@xxxxxxxxxxxx>
Commit: Dan McMahill <dan@xxxxxxxxxxxx>
Remove some gcc warnings.
Add missing headers for fork(), execvp(), wait(). Also remove
a couple of unused variables.
diff --git a/configure.ac b/configure.ac
index 115bf91..f8001e3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -630,7 +630,7 @@ libiberty_NEED_DECLARATION(canonicalize_file_name)
AC_HEADER_STDC
AC_CHECK_HEADERS(limits.h locale.h string.h sys/types.h regex.h pwd.h)
-AC_CHECK_HEADERS(sys/socket.h netinet/in.h netdb.h sys/param.h sys/times.h)
+AC_CHECK_HEADERS(sys/socket.h netinet/in.h netdb.h sys/param.h sys/times.h sys/wait.h)
AC_CHECK_HEADERS(dlfcn.h)
if test "x${WIN32}" = "xyes" ; then
diff --git a/src/action.c b/src/action.c
index cbf3223..f2b04a6 100644
--- a/src/action.c
+++ b/src/action.c
@@ -1,4 +1,3 @@
-/* $Id$ */
/* 15 Oct 2008 Ineiev: add CycleCrosshair action */
/*
@@ -76,7 +75,14 @@
#include <dmalloc.h>
#endif
-RCSID ("$Id$");
+/* for fork() and friends */
+#ifdef HAVE_UNISTD_H
+#include <unistd.h>
+#endif
+
+#ifdef HAVE_SYS_WAIT_H
+#include <sys/wait.h>
+#endif
/* ---------------------------------------------------------------------------
* some local types
@@ -7225,7 +7231,7 @@ ActionImport (int argc, char **argv, int x, int y)
{
char *tmpfile = tmpnam (NULL);
char **cmd;
- int i, pid;
+ int i;
cmd = (char **) malloc ((6 + nsources) * sizeof (char *));
cmd[0] = "gnetlist";
cmd[1] = "-g";
@@ -7253,7 +7259,7 @@ ActionImport (int argc, char **argv, int x, int y)
{
char *tmpfile = tmpnam (NULL);
char **cmd;
- int i, pid;
+ int i;
char *srclist;
int srclen;
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs