[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: branch: master updated (1.3.0-20071229-64-gd9e2455)
The branch, master has been updated
via d9e245524db9399a11fe533a2f4caccb06d89f75 (commit)
via 9f96048f1c9c9989f709e8b07d6195628fd79115 (commit)
from 0dfb874e72040b74679152d75ab2e50b735bdbd4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
gsymcheck/include/Makefile.am | 3 +-
gsymcheck/include/pincounts.h | 43 --------------------
gsymcheck/include/prototype.h | 1 -
gsymcheck/include/struct.h | 1 -
gsymcheck/src/s_check.c | 43 --------------------
gsymcheck/src/s_symstruct.c | 1 -
gsymcheck/tests/Makefile.am | 6 +-
gsymcheck/tests/incorrect_footprint.output | 3 -
gsymcheck/tests/incorrect_footprint.sym | 59 ----------------------------
9 files changed, 4 insertions(+), 156 deletions(-)
delete mode 100644 gsymcheck/include/pincounts.h
delete mode 100644 gsymcheck/tests/incorrect_footprint.output
delete mode 100644 gsymcheck/tests/incorrect_footprint.sym
=================
Commit Messages
=================
commit d9e245524db9399a11fe533a2f4caccb06d89f75
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Thu Jan 10 21:06:30 2008 -0500
Added new off pin grid symbol and golden output to EXTRA_DIST
:100644 100644 449e7e5... 50741b7... M gsymcheck/tests/Makefile.am
commit 9f96048f1c9c9989f709e8b07d6195628fd79115
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Thu Jan 10 21:02:45 2008 -0500
Removed misleading "pin count from footprint=" attribute check
This check wasn't working correctly for all footprint= values.
It probably worked fine for the DIP# and related footprints (ending
with the number of pins in the footprin), but for others it was giving
incorrect info/warnings. This check will be replaced with something a
little bit more flexible going forward in a later release.
:100644 100644 cc602c7... d8cfb92... M gsymcheck/include/Makefile.am
:100644 000000 0ccb3f8... 0000000... D gsymcheck/include/pincounts.h
:100644 100644 48d9d82... 8d2c0cc... M gsymcheck/include/prototype.h
:100644 100644 1bfb3ba... 3c3c567... M gsymcheck/include/struct.h
:100644 100644 f41ec20... ae5f059... M gsymcheck/src/s_check.c
:100644 100644 b5a0aaa... da9df11... M gsymcheck/src/s_symstruct.c
:100644 100644 3791dc2... 449e7e5... M gsymcheck/tests/Makefile.am
:100644 000000 2f825f5... 0000000... D gsymcheck/tests/incorrect_footprint.output
:100644 000000 94980af... 0000000... D gsymcheck/tests/incorrect_footprint.sym
=========
Changes
=========
commit d9e245524db9399a11fe533a2f4caccb06d89f75
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Thu Jan 10 21:06:30 2008 -0500
Added new off pin grid symbol and golden output to EXTRA_DIST
diff --git a/gsymcheck/tests/Makefile.am b/gsymcheck/tests/Makefile.am
index 449e7e5..50741b7 100644
--- a/gsymcheck/tests/Makefile.am
+++ b/gsymcheck/tests/Makefile.am
@@ -12,7 +12,7 @@ EXTRA_DIST = buses.sym connections1.sym connections2.sym connections3.sym \
nameinside.sym nets.sym noslots.sym old_symbol.sym oldpins.sym \
oldslot.sym typeinside.sym urefinside.sym zero_pinnumber.sym \
zero_pinseq.sym zero_slotnum.sym zero_slots.sym \
- duplicate_net.sym \
+ duplicate_net.sym pin_offgrid.sym \
runtest.sh \
buses.output connections1.output connections2.output \
connections3.output correct.output duplicate_net.output \
@@ -31,7 +31,7 @@ EXTRA_DIST = buses.sym connections1.sym connections2.sym connections3.sym \
nameinside.output nets.output noslots.output oldpins.output \
oldslot.output old_symbol.output typeinside.output \
urefinside.output zero_pinnumber.output zero_pinseq.output \
- zero_slotnum.output zero_slots.output
+ zero_slotnum.output zero_slots.output pin_offgrid.output
check_SCRIPTS = tests
commit 9f96048f1c9c9989f709e8b07d6195628fd79115
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Thu Jan 10 21:02:45 2008 -0500
Removed misleading "pin count from footprint=" attribute check
This check wasn't working correctly for all footprint= values.
It probably worked fine for the DIP# and related footprints (ending
with the number of pins in the footprin), but for others it was giving
incorrect info/warnings. This check will be replaced with something a
little bit more flexible going forward in a later release.
diff --git a/gsymcheck/include/Makefile.am b/gsymcheck/include/Makefile.am
index cc602c7..d8cfb92 100644
--- a/gsymcheck/include/Makefile.am
+++ b/gsymcheck/include/Makefile.am
@@ -1,7 +1,6 @@
## Process this file with automake to produce Makefile.in
-noinst_HEADERS = globals.h i_vars.h papersizes.h prototype.h struct.h \
- pincounts.h
+noinst_HEADERS = globals.h i_vars.h papersizes.h prototype.h struct.h
MOSTLYCLEANFILES = *.log core FILE *~
CLEANFILES = *.log core FILE *~
diff --git a/gsymcheck/include/pincounts.h b/gsymcheck/include/pincounts.h
deleted file mode 100644
index 0ccb3f8..0000000
--- a/gsymcheck/include/pincounts.h
+++ /dev/null
@@ -1,43 +0,0 @@
-/* pincounts.h */
-
-typedef struct st_pincount PINCOUNT;
-
-struct st_pincount {
- char *footprint;
- int pincount;
-};
-
-static PINCOUNT p_pincounts[] = {
- { "footprint=TO92", 3 },
- { "footprint=TO-220AB", 3 },
- { NULL, 3 },
- };
-
-
-int s_get_footprint_size(char *footprint)
-{
- PINCOUNT *pcount = p_pincounts;
- char *tmp;
-
- while(pcount->footprint != NULL) {
- if (!strcasecmp(footprint, pcount->footprint))
- return pcount->pincount;
- pcount++;
- }
-
- tmp = &footprint[strlen(footprint)-1];
-
- while((*tmp >= '0') && (*tmp <= '9'))
- {
- if (tmp == footprint)
- return -1;
- tmp--;
- }
- tmp++;
-
- if (*tmp == '\0')
- return -1;
-
- return atoi(tmp);
-}
-
diff --git a/gsymcheck/include/prototype.h b/gsymcheck/include/prototype.h
index 48d9d82..8d2c0cc 100644
--- a/gsymcheck/include/prototype.h
+++ b/gsymcheck/include/prototype.h
@@ -31,7 +31,6 @@ void s_check_connections(OBJECT *object_head, SYMCHECK *s_current);
void s_check_obsolete_forbidden_attributes(OBJECT *object_head, SYMCHECK *s_current);
void s_check_missing_attribute(OBJECT *object, char *attribute, SYMCHECK *s_current);
void s_check_missing_attributes(OBJECT *object_head, SYMCHECK *s_current);
-void s_check_totalpins(OBJECT *object_head, SYMCHECK *s_current);
void s_check_pintype(OBJECT *object_head, SYMCHECK *s_current);
/* s_symstruct.c */
SYMCHECK *s_symstruct_init(void);
diff --git a/gsymcheck/include/struct.h b/gsymcheck/include/struct.h
index 1bfb3ba..3c3c567 100644
--- a/gsymcheck/include/struct.h
+++ b/gsymcheck/include/struct.h
@@ -52,7 +52,6 @@ struct st_symcheck {
/* misc attributes */
int found_footprint;
- int footprint_size;
int found_refdes;
/* number of pins */
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index f41ec20..ae5f059 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -36,7 +36,6 @@
#include "../include/struct.h"
#include "../include/globals.h"
#include "../include/prototype.h"
-#include "../include/pincounts.h"
int
s_check_all(TOPLEVEL *pr_current)
@@ -118,10 +117,6 @@ s_check_symbol(TOPLEVEL *pr_current, PAGE *p_current, OBJECT *object_head)
/* check for connections with in a symbol (completely disallowed) */
s_check_connections(object_head, s_symcheck);
- /* Check to make sure the total number of pins is correct */
- s_check_totalpins(object_head, s_symcheck);
-
-
/* now report the info/warnings/errors to the user */
if (!quiet_mode) {
@@ -1282,17 +1277,6 @@ s_check_missing_attributes(OBJECT *object_head, SYMCHECK *s_current)
o_current->text->string);
s_current->info_messages = g_list_append(s_current->info_messages,
message);
-
-
- s_current->footprint_size = s_get_footprint_size(
- o_current->text->string);
-
- message = g_strdup_printf (
- "Footprint size is %d.\n",
- s_current->footprint_size);
- s_current->info_messages = g_list_append(s_current->info_messages,
- message);
-
s_current->found_footprint++;
}
@@ -1342,33 +1326,6 @@ s_check_missing_attributes(OBJECT *object_head, SYMCHECK *s_current)
}
-void
-s_check_totalpins(OBJECT *object_head, SYMCHECK *s_current)
-{
- int totalpins = 0;
- char *message;
-
- totalpins = s_current->numnetpins;
-
- if (s_current->numslots)
- if (s_current->numslotpins)
- totalpins += s_current->numslotpins;
- else
- totalpins += s_current->numpins * s_current->numslots;
- else
- totalpins += s_current->numpins;
-
- if (totalpins != s_current->footprint_size &&
- s_current->footprint_size != -1) {
- message = g_strdup ("Number of pins does not match footprint size.\n");
- s_current->warning_messages = g_list_append(s_current->warning_messages,
- message);
- s_current->warning_count++;
- }
-
-
-}
-
void s_check_pintype(OBJECT *object_head, SYMCHECK *s_current)
{
OBJECT *o_current;
diff --git a/gsymcheck/src/s_symstruct.c b/gsymcheck/src/s_symstruct.c
index b5a0aaa..da9df11 100644
--- a/gsymcheck/src/s_symstruct.c
+++ b/gsymcheck/src/s_symstruct.c
@@ -71,7 +71,6 @@ s_symstruct_init(void)
s_symcheck->found_footprint=FALSE;
s_symcheck->found_refdes=FALSE;
- s_symcheck->footprint_size = -1;
s_symcheck->numpins=0;
s_symcheck->numnetpins=0;
s_symcheck->numslots=0;
diff --git a/gsymcheck/tests/Makefile.am b/gsymcheck/tests/Makefile.am
index 3791dc2..449e7e5 100644
--- a/gsymcheck/tests/Makefile.am
+++ b/gsymcheck/tests/Makefile.am
@@ -12,13 +12,13 @@ EXTRA_DIST = buses.sym connections1.sym connections2.sym connections3.sym \
nameinside.sym nets.sym noslots.sym old_symbol.sym oldpins.sym \
oldslot.sym typeinside.sym urefinside.sym zero_pinnumber.sym \
zero_pinseq.sym zero_slotnum.sym zero_slots.sym \
- incorrect_footprint.sym duplicate_net.sym \
+ duplicate_net.sym \
runtest.sh \
buses.output connections1.output connections2.output \
connections3.output correct.output duplicate_net.output \
duplicate_pinnumber.output duplicate_pinseq.output \
graphical_correct.output graphical_incorrect.output \
- incorrect_footprint.output invalid_slotdef1.output \
+ invalid_slotdef1.output \
invalid_slotdef2.output invalid_slotdef3.output \
invalid_slotdef4.output labelinside.output lots_of_errors.output \
many_slotdefs.output missing_device.output \
diff --git a/gsymcheck/tests/incorrect_footprint.output b/gsymcheck/tests/incorrect_footprint.output
deleted file mode 100644
index 2f825f5..0000000
--- a/gsymcheck/tests/incorrect_footprint.output
+++ /dev/null
@@ -1,3 +0,0 @@
-Warning: Number of pins does not match footprint size.
-1 warnings found
-No errors found
diff --git a/gsymcheck/tests/incorrect_footprint.sym b/gsymcheck/tests/incorrect_footprint.sym
deleted file mode 100644
index 94980af..0000000
--- a/gsymcheck/tests/incorrect_footprint.sym
+++ /dev/null
@@ -1,59 +0,0 @@
-v 20041228 1
-L 300 200 300 800 3 0 0 0 -1 -1
-T 300 0 9 8 1 0 0 0 1
-7400
-L 300 800 700 800 3 0 0 0 -1 -1
-T 500 900 5 10 0 0 0 0 1
-device=7400
-T 800 1000 5 10 1 0 0 0 1
-footprint=DIP8
-T 500 1100 5 10 0 0 0 0 1
-slot=1
-T 500 1300 5 10 0 0 0 0 1
-numslots=4
-T 500 1500 5 10 0 0 0 0 1
-slotdef=1:1,2,3
-T 500 1700 5 10 0 0 0 0 1
-slotdef=2:4,5,6
-T 500 1900 5 10 0 0 0 0 1
-slotdef=3:9,10,8
-T 500 2100 5 10 0 0 0 0 1
-slotdef=4:12,13,11
-L 300 200 700 200 3 0 0 0 -1 -1
-A 700 500 300 270 180 3 0 0 0 -1 -1
-V 1050 500 50 6 0 0 0 -1 -1 0 -1 -1 -1 -1 -1
-P 1100 500 1300 500 1 0 1
-{
-T 1085 350 5 8 0 0 0 0 1
-pinseq=3
-T 1085 550 5 8 1 1 0 0 1
-pinnumber=3
-T 1085 350 5 8 0 0 0 0 1
-pinlabel=C
-T 1085 350 5 8 0 0 0 0 1
-pintype=out
-}
-P 300 300 0 300 1 0 1
-{
-T 0 150 5 8 0 0 0 0 1
-pinseq=2
-T 100 350 5 8 1 1 0 0 1
-pinnumber=2
-T 0 150 5 8 0 0 0 0 1
-pinlabel=B
-T 0 150 5 8 0 0 0 0 1
-pintype=in
-}
-P 300 700 0 700 1 0 1
-{
-T 0 550 5 8 0 0 0 0 1
-pinseq=1
-T 100 750 5 8 1 1 0 0 1
-pinnumber=1
-T 0 550 5 8 0 0 0 0 1
-pinlabel=A
-T 0 550 5 8 0 0 0 0 1
-pintype=in
-}
-T 300 900 8 10 1 1 0 0 1
-refdes=U?
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs