gEDA-cvs: branch: master updated (1.3.0-20071229-65-g6ac1f25)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  6ac1f25c4a2d88c1e5825aac74265cf442680954 (commit)
      from  d9e245524db9399a11fe533a2f4caccb06d89f75 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/src/f_basic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


=================
 Commit Messages
=================

commit 6ac1f25c4a2d88c1e5825aac74265cf442680954
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Fri Jan 11 04:44:32 2008 +0000

    Fix invalid memory access with auto-save filename being used after free.
    
    Use the "full_filename" variable in f_open_flags() as a base for the
    auto-save filename. Previous code uses the passed in "filename" argument,
    however in some cases this argument points to memory which is free'd in
    f_open_flags() after determining "full_filename".

:100644 100644 9de4366... cfaf94b... M	libgeda/src/f_basic.c

=========
 Changes
=========

commit 6ac1f25c4a2d88c1e5825aac74265cf442680954
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Fri Jan 11 04:44:32 2008 +0000

    Fix invalid memory access with auto-save filename being used after free.
    
    Use the "full_filename" variable in f_open_flags() as a base for the
    auto-save filename. Previous code uses the passed in "filename" argument,
    however in some cases this argument points to memory which is free'd in
    f_open_flags() after determining "full_filename".

diff --git a/libgeda/src/f_basic.c b/libgeda/src/f_basic.c
index 9de4366..cfaf94b 100644
--- a/libgeda/src/f_basic.c
+++ b/libgeda/src/f_basic.c
@@ -235,8 +235,8 @@ int f_open_flags(TOPLEVEL *toplevel, const gchar *filename,
   if (flags & F_OPEN_CHECK_BACKUP) {
     /* Check if there is a newer autosave backup file */
     GString *message;
-    gboolean active_backup = f_has_active_autosave (filename, &tmp_err);
-    backup_filename = f_get_autosave_filename (filename);
+    gboolean active_backup = f_has_active_autosave (full_filename, &tmp_err);
+    backup_filename = f_get_autosave_filename (full_filename);
 
     if (tmp_err != NULL) g_warning ("%s\n", tmp_err->message);
     if (active_backup) {




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs