[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: branch: master updated (1.4.0-20080127-5-ge1ba38c)
The branch, master has been updated
via e1ba38c43fb8d0fda7609e607e5489046fef4a8f (commit)
via 77e0e0f4ffe9573316ebdfdc12d319ccff1074a3 (commit)
via a6f4710a198a8bcb66b8a26185ad7bd60c6c599a (commit)
via b14328d429866910fc2a1da2e8291467e3fc27b9 (commit)
from 22396b286d50c454287ff94a3c3de414b3f9a08a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
gsymcheck/src/s_check.c | 285 ++++++++++++--------------
gsymcheck/tests/duplicate_net.output | 6 +-
gsymcheck/tests/duplicate_net.sym | 10 +-
gsymcheck/tests/duplicate_pinnumber.output | 3 +-
gsymcheck/tests/lots_of_errors.output | 5 +-
gsymcheck/tests/misplaced_attributes.output | 3 +-
gsymcheck/tests/old_symbol.output | 9 +-
gsymcheck/tests/oldpins.output | 4 +
gsymcheck/tests/oldslot.output | 5 +
9 files changed, 166 insertions(+), 164 deletions(-)
=================
Commit Messages
=================
commit e1ba38c43fb8d0fda7609e607e5489046fef4a8f
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sat Jan 19 19:45:29 2008 +0100
gsymcheck: modified symbol for improved duplicate net test
:100644 100644 82c8522... b5ea46c... M gsymcheck/tests/duplicate_net.output
:100644 100644 6c202b7... e61ea6a... M gsymcheck/tests/duplicate_net.sym
commit 77e0e0f4ffe9573316ebdfdc12d319ccff1074a3
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Mon Jan 14 19:49:49 2008 +0100
gsymcheck: test for number in pinlabel and net attribute
If a number is in a net attribute and a value of any pinlabel
attribute then print a warning with some text. The previous patch
removed the error message, this one adds warning. Whether this
situation is an error or not depends on the users intention.
:100644 100644 c5451b7... 26c714e... M gsymcheck/src/s_check.c
:100644 100644 7853e01... 82c8522... M gsymcheck/tests/duplicate_net.output
commit a6f4710a198a8bcb66b8a26185ad7bd60c6c599a
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sun Jan 13 20:42:55 2008 +0100
gsymcheck: improved pinnumber check
The changes will check for duplicate pins in net definitions.
It also checks the net definitions and the pinlabel definition
seperatly, thus a power pin can have a pinlabel and a net pin.
:100644 100644 71d33f0... c5451b7... M gsymcheck/src/s_check.c
:100644 100644 50423f0... 6802f4b... M gsymcheck/tests/duplicate_pinnumber.output
commit b14328d429866910fc2a1da2e8291467e3fc27b9
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sun Jan 13 18:08:51 2008 +0100
gsymcheck: check for unknown attributes
This test will check for all attributes that are not in a valid
attributes list. A warning messages is printed. This will also catch
old style attributes like slot#=# and pin#=#.
And some often used attributes class, pins, footprint2.
:100644 100644 f6483a0... 71d33f0... M gsymcheck/src/s_check.c
:100644 100644 4d511e8... 124c037... M gsymcheck/tests/lots_of_errors.output
:100644 100644 8a84858... 5963598... M gsymcheck/tests/misplaced_attributes.output
:100644 100644 85e0318... b7f967c... M gsymcheck/tests/old_symbol.output
:100644 100644 fa0982a... 1fa195b... M gsymcheck/tests/oldpins.output
:100644 100644 4904107... 09328bc... M gsymcheck/tests/oldslot.output
=========
Changes
=========
commit e1ba38c43fb8d0fda7609e607e5489046fef4a8f
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sat Jan 19 19:45:29 2008 +0100
gsymcheck: modified symbol for improved duplicate net test
diff --git a/gsymcheck/tests/duplicate_net.output b/gsymcheck/tests/duplicate_net.output
index 82c8522..b5ea46c 100644
--- a/gsymcheck/tests/duplicate_net.output
+++ b/gsymcheck/tests/duplicate_net.output
@@ -1,3 +1,5 @@
Warning: Found the same number in a pinnumber attribute and in a net attribute [1]
+ERROR: Found duplicate pin in net= attributes [5]
+ERROR: Found duplicate pin in net= attributes [6]
1 warnings found
-No errors found
+2 ERRORS found
diff --git a/gsymcheck/tests/duplicate_net.sym b/gsymcheck/tests/duplicate_net.sym
index 6c202b7..e61ea6a 100644
--- a/gsymcheck/tests/duplicate_net.sym
+++ b/gsymcheck/tests/duplicate_net.sym
@@ -1,11 +1,11 @@
-v 20041228 1
+v 20080110 1
L 300 200 300 800 3 0 0 0 -1 -1
T 300 0 9 8 1 0 0 0 1
7400
L 300 800 700 800 3 0 0 0 -1 -1
T 500 900 5 10 0 0 0 0 1
device=7400
-T 1200 1100 5 10 0 0 0 0 1
+T 500 2300 5 10 0 0 0 0 1
footprint=unspecified
T 500 1100 5 10 0 0 0 0 1
slot=1
@@ -57,5 +57,7 @@ pintype=in
}
T 300 900 8 10 1 1 0 0 1
refdes=U?
-T 700 900 8 10 1 0 0 0 1
-net=INVALID:1
+T 1800 1100 8 10 1 0 0 0 1
+net=INVALID:1,5
+T 1800 900 8 10 1 0 0 0 1
+net=INVALID:5,6,6
commit 77e0e0f4ffe9573316ebdfdc12d319ccff1074a3
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Mon Jan 14 19:49:49 2008 +0100
gsymcheck: test for number in pinlabel and net attribute
If a number is in a net attribute and a value of any pinlabel
attribute then print a warning with some text. The previous patch
removed the error message, this one adds warning. Whether this
situation is an error or not depends on the users intention.
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index c5451b7..26c714e 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -455,10 +455,9 @@ s_check_pinnumber(OBJECT *object_head, SYMCHECK *s_current)
GList *net_numbers = NULL;
GList *pin_numbers = NULL;
GList *cur = NULL;
+ GList *cur2 = NULL;
char *message;
char *net = NULL;
-
-
/* collect all net pins */
for (counter = 0;
@@ -466,7 +465,7 @@ s_check_pinnumber(OBJECT *object_head, SYMCHECK *s_current)
counter++) {
message = g_strdup_printf ("Found net=%s attribute\n", net);
s_current->info_messages = g_list_append(s_current->info_messages,
- message);
+ message);
net_tokens = g_strsplit(net,":", -1);
/* length of net tokens have to be 2 */
@@ -568,7 +567,7 @@ s_check_pinnumber(OBJECT *object_head, SYMCHECK *s_current)
}
}
- /* check for duplicate net_numbers */
+ /* check for duplicate pinlabel numbers */
pin_numbers = g_list_sort(pin_numbers, (GCompareFunc)strcmp);
for (cur = pin_numbers;
cur != NULL && g_list_next(cur) != NULL;
@@ -589,6 +588,33 @@ s_check_pinnumber(OBJECT *object_head, SYMCHECK *s_current)
}
}
+ /* Check for all pins that are in both lists and print a warning.
+ Sometimes this is useful and sometimes it's an error. */
+
+ cur = net_numbers;
+ cur2 = pin_numbers;
+
+ while (cur != NULL && cur2 != NULL) {
+
+ i = strcmp((gchar*)cur->data, (gchar*)cur2->data);
+
+ if (i == 0) {
+ message = g_strdup_printf ("Found the same number in a pinnumber "
+ "attribute and in a net attribute [%s]\n",
+ (gchar*) cur->data);
+ s_current->warning_messages = g_list_append(s_current->warning_messages,
+ message);
+ s_current->warning_count++;
+ cur = g_list_next(cur);
+
+ } else if ( i > 0 ) {
+ cur2 = g_list_next(cur2);
+
+ } else { /* i < 0 */
+ cur = g_list_next(cur);
+ }
+ }
+
/* FIXME: this is not correct if a pinnumber is defined as pinnumber and
inside a net. We have to calculate the union set */
message = g_strdup_printf ("Found %d pins inside symbol\n",
diff --git a/gsymcheck/tests/duplicate_net.output b/gsymcheck/tests/duplicate_net.output
index 7853e01..82c8522 100644
--- a/gsymcheck/tests/duplicate_net.output
+++ b/gsymcheck/tests/duplicate_net.output
@@ -1,3 +1,3 @@
-ERROR: Found duplicate pinnumber=1 attribute in the symbol
-ERROR: Found duplicate pinnumber=1 attribute in the symbol
-2 ERRORS found
+Warning: Found the same number in a pinnumber attribute and in a net attribute [1]
+1 warnings found
+No errors found
commit a6f4710a198a8bcb66b8a26185ad7bd60c6c599a
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sun Jan 13 20:42:55 2008 +0100
gsymcheck: improved pinnumber check
The changes will check for duplicate pins in net definitions.
It also checks the net definitions and the pinlabel definition
seperatly, thus a power pin can have a pinlabel and a net pin.
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index 71d33f0..c5451b7 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -445,208 +445,163 @@ s_check_pinnumber(OBJECT *object_head, SYMCHECK *s_current)
{
OBJECT *o_current;
char *string;
- int found_first=FALSE;
int missing_pinnumber_attrib_sum=0;
int multiple_pinnumber_attrib_sum=0;
int counter=0;
- int j;
+ int i;
- GList *found_numbers = NULL;
- GList *ptr1 = NULL;
- GList *ptr2 = NULL;
- char *number = NULL;
+ gchar **net_tokens;
+ gchar **pin_tokens;
+ GList *net_numbers = NULL;
+ GList *pin_numbers = NULL;
+ GList *cur = NULL;
char *message;
char *net = NULL;
- char *temp;
- char *netpins = NULL;
- char tempstr[10];
-
- counter = 0;
- while( (net = o_attrib_search_toplevel(object_head, "net", counter)) != NULL)
- {
+
+
+ /* collect all net pins */
+ for (counter = 0;
+ (net = o_attrib_search_toplevel(object_head, "net", counter)) != NULL;
+ counter++) {
message = g_strdup_printf ("Found net=%s attribute\n", net);
s_current->info_messages = g_list_append(s_current->info_messages,
message);
- netpins = u_basic_breakup_string(net, ':', 1);
-
- if (!netpins) {
- message = g_strdup ("Bad net= attribute\n");
+ net_tokens = g_strsplit(net,":", -1);
+ /* length of net tokens have to be 2 */
+ if (net_tokens[1] == NULL) {
+ message = g_strdup_printf ("Bad net= attribute [net=%s]\n", net);
s_current->error_messages = g_list_append(s_current->error_messages,
- message);
+ message);
s_current->error_count++;
-
- g_free(net);
- counter++;
+ g_strfreev(net_tokens);
+ continue;
+ } else if (net_tokens[2] != NULL) { /* more than 2 tokens */
+ message = g_strdup_printf ("Bad net= attribute [net=%s]\n", net);
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ s_current->error_count++;
+ g_strfreev(net_tokens);
continue;
}
-
- j = 0;
- do {
- if (number) {
- g_free(number);
- number = NULL;
- }
-
- number = u_basic_breakup_string(netpins, ',', j);
-
- if (!number)
- break;
+ pin_tokens = g_strsplit(net_tokens[1],",",-1);
+
+ for (i = 0; pin_tokens[i] != NULL; i++) {
+ net_numbers = g_list_append(net_numbers, g_strdup(pin_tokens[i]));
message = g_strdup_printf ("Found pin number %s in net attribute\n",
- number);
+ pin_tokens[i]);
s_current->info_messages = g_list_append(s_current->info_messages,
- message);
-
-
- if (strcmp(number, "0") == 0) {
- message = g_strdup ("Found pinnumber 0 in net= attribute\n");
- s_current->error_messages = g_list_append(s_current->error_messages,
- message);
- s_current->error_count++;
- }
-
- temp = g_strdup(number);
- found_numbers = g_list_append(found_numbers, temp);
-
+ message);
s_current->numnetpins++;
-
- j++;
- } while (number);
-
- if (number)
- g_free(number);
-
-
+ }
g_free(net);
- g_free(netpins);
-
- counter++;
+ g_strfreev(net_tokens);
+ g_strfreev(pin_tokens);
+ }
+
+ /* check for duplicate net pin numbers */
+ net_numbers = g_list_sort(net_numbers, (GCompareFunc)strcmp);
+
+ for (cur = net_numbers;
+ cur != NULL && g_list_next(cur) != NULL;
+ cur = g_list_next(cur)) {
+ if (strcmp((gchar*)cur->data, (gchar*) cur->next->data) == 0) {
+ message = g_strdup_printf ("Found duplicate pin in net= "
+ "attributes [%s]\n", (gchar*) cur->data);
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ s_current->error_count++;
+ }
+ if (strcmp((gchar*) cur->data, "0") == 0) {
+ message = g_strdup ("Found pinnumber 0 in net= attribute\n");
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ s_current->error_count++;
+ }
}
-
- o_current = object_head;
- while(o_current != NULL)
- {
+ /* collect all pin numbers */
+ for (o_current = object_head; o_current != NULL;
+ o_current = o_current->next) {
- if (o_current->type == OBJ_PIN)
- {
+ if (o_current->type == OBJ_PIN) {
s_current->numpins++;
missing_pinnumber_attrib_sum = 0;
multiple_pinnumber_attrib_sum = 0;
- found_first = FALSE;
- counter = 0;
- string = o_attrib_search_name_single_count(o_current, "pinnumber",
- counter);
- if (!string)
- {
- message = g_strdup ("Missing pinnumber= attribute\n");
- s_current->error_messages = g_list_append(s_current->error_messages,
- message);
- missing_pinnumber_attrib_sum++;
- s_current->error_count++;
- }
-
- while (string)
- {
+ for (counter = 0;
+ (string = o_attrib_search_name_single_count(o_current, "pinnumber",
+ counter)) != NULL;
+ counter++) {
+
message = g_strdup_printf ("Found pinnumber=%s attribute\n", string);
s_current->info_messages = g_list_append(s_current->info_messages,
message);
- if (found_first) {
- message = g_strdup_printf (
- "Found multiple pinnumber=%s attributes on one pin\n",
- string);
+ if (counter == 0) { /* collect the first appearance */
+ pin_numbers = g_list_append(pin_numbers, string);
+ }
+ if (counter >= 1) {
+ message = g_strdup_printf ("Found multiple pinnumber=%s attributes"
+ " on one pin\n", string);
s_current->error_messages = g_list_append(s_current->error_messages,
message);
multiple_pinnumber_attrib_sum++;
s_current->error_count++;
+ g_free(string);
}
-
- number = g_strdup (string);
- g_free(string);
-
- if (strcmp(number, "0") == 0) {
- message = g_strdup ("Found pinnumber=0 attribute\n");
- s_current->error_messages = g_list_append(s_current->error_messages,
- message);
- s_current->error_count++;
- }
-
- /* this is the first attribute found */
- if (!found_first) {
- found_numbers = g_list_append(found_numbers, number);
- found_first=TRUE;
- } else {
- if (number)
- g_free(number);
- }
-
- counter++;
- string = o_attrib_search_name_single_count(o_current, "pinnumber",
- counter);
+ }
+
+ if (counter == 0) {
+ message = g_strdup ("Missing pinnumber= attribute\n");
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ missing_pinnumber_attrib_sum++;
+ s_current->error_count++;
}
s_current->missing_pinnumber_attrib += missing_pinnumber_attrib_sum;
s_current->multiple_pinnumber_attrib += multiple_pinnumber_attrib_sum;
}
-
- o_current = o_current->next;
}
-
-
-
- ptr1 = found_numbers;
- while (ptr1)
- {
- char *string = (char *) ptr1->data;
- int found = 0;
-
- ptr2 = found_numbers;
- while(ptr2 && string)
- {
- char *current = (char *) ptr2->data;
-
- if (current && strcmp(string, current) == 0) {
- found++;
- }
-
- ptr2 = g_list_next(ptr2);
- }
-
- if (found > 1)
- {
- message = g_strdup_printf (
- "Found duplicate pinnumber=%s attribute in the symbol\n",
- string);
+ /* check for duplicate net_numbers */
+ pin_numbers = g_list_sort(pin_numbers, (GCompareFunc)strcmp);
+ for (cur = pin_numbers;
+ cur != NULL && g_list_next(cur) != NULL;
+ cur = g_list_next(cur)) {
+ if (strcmp((gchar*)cur->data, (gchar*) cur->next->data) == 0) {
+ message = g_strdup_printf ("Found duplicate pinnumber=%s attribute "
+ "in the symbol\n", (gchar*) cur->data);
s_current->error_messages = g_list_append(s_current->error_messages,
- message);
+ message);
s_current->error_count++;
s_current->duplicate_pinnumber_attrib++;
}
-
- ptr1 = g_list_next(ptr1);
- }
-
- ptr1 = found_numbers;
- while (ptr1)
- {
- g_free(ptr1->data);
- ptr1 = g_list_next(ptr1);
+ if (strcmp((gchar*) cur->data, "0") == 0) {
+ message = g_strdup ("Found pinnumber=0 attribute\n");
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ s_current->error_count++;
+ }
}
- g_list_free(found_numbers);
-
- sprintf(tempstr, "%d", s_current->numpins + s_current->numnetpins);
- message = g_strdup_printf ("Found %s pins inside symbol\n", tempstr);
+ /* FIXME: this is not correct if a pinnumber is defined as pinnumber and
+ inside a net. We have to calculate the union set */
+ message = g_strdup_printf ("Found %d pins inside symbol\n",
+ s_current->numpins + s_current->numnetpins);
s_current->info_messages = g_list_append(s_current->info_messages,
message);
+ g_list_foreach(pin_numbers, (GFunc) g_free, NULL);
+ g_list_free(pin_numbers);
+ g_list_foreach(net_numbers, (GFunc) g_free, NULL);
+ g_list_free(net_numbers);
}
+
void
s_check_pin_ongrid(OBJECT *object_head, SYMCHECK *s_current)
{
diff --git a/gsymcheck/tests/duplicate_pinnumber.output b/gsymcheck/tests/duplicate_pinnumber.output
index 50423f0..6802f4b 100644
--- a/gsymcheck/tests/duplicate_pinnumber.output
+++ b/gsymcheck/tests/duplicate_pinnumber.output
@@ -1,3 +1,2 @@
ERROR: Found duplicate pinnumber=2 attribute in the symbol
-ERROR: Found duplicate pinnumber=2 attribute in the symbol
-2 ERRORS found
+1 ERROR found
commit b14328d429866910fc2a1da2e8291467e3fc27b9
Author: Werner Hoch <werner.ho@xxxxxx>
Date: Sun Jan 13 18:08:51 2008 +0100
gsymcheck: check for unknown attributes
This test will check for all attributes that are not in a valid
attributes list. A warning messages is printed. This will also catch
old style attributes like slot#=# and pin#=#.
And some often used attributes class, pins, footprint2.
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index f6483a0..71d33f0 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -190,7 +190,7 @@ s_check_symbol_structure(OBJECT *object_head, SYMCHECK *s_current)
"author", "comment", "numslots",
"slotdef", "footprint", "documentation",
"refdes", "slot", "net", "value",
- "symversion", "dist-license",
+ "symversion", "dist-license", "use-license",
NULL};
char *obsolete_attributes[] = {"uref", "label", "email",
NULL};
@@ -230,13 +230,11 @@ s_check_symbol_structure(OBJECT *object_head, SYMCHECK *s_current)
}
}
else if (!s_check_list_has_item(valid_attributes, tokens[0])) {
-#if 0
message = g_strdup_printf ("Found unknown %s= attribute: [%s=%s]\n",
- token[0], tokens[0], tokens[1]);
+ tokens[0], tokens[0], tokens[1]);
s_current->warning_messages =
g_list_append(s_current->warning_messages, message);
s_current->warning_count++;
-#endif
}
else if (o_current->attached_to != NULL) {
message = g_strdup_printf ("Found wrongly attached attribute: "
diff --git a/gsymcheck/tests/lots_of_errors.output b/gsymcheck/tests/lots_of_errors.output
index 4d511e8..124c037 100644
--- a/gsymcheck/tests/lots_of_errors.output
+++ b/gsymcheck/tests/lots_of_errors.output
@@ -1,3 +1,6 @@
+Warning: Found unknown device_missing= attribute: [device_missing=7400]
+Warning: Found unknown pinnumbe= attribute: [pinnumbe=3]
+Warning: Found unknown pineq= attribute: [pineq=2]
Warning: Found obsolete uref= attribute: [uref=U?]
Warning: Missing pinlabel= attribute
Warning: Missing pintype= attribute
@@ -15,5 +18,5 @@ ERROR: Not enough pins in slotdef=2:4,5
ERROR: Slot 8 is larger then the maximum number (5) of slots
ERROR: Invalid slotdef=a attributes, not continuing
ERROR: Malformed slotdef= (the format is #:#,#,#,...)
-9 warnings found
+12 warnings found
8 ERRORS found
diff --git a/gsymcheck/tests/misplaced_attributes.output b/gsymcheck/tests/misplaced_attributes.output
index 8a84858..5963598 100644
--- a/gsymcheck/tests/misplaced_attributes.output
+++ b/gsymcheck/tests/misplaced_attributes.output
@@ -1,4 +1,5 @@
Warning: Found obsolete label= attribute: [label=2]
+Warning: Found unknown xxxxx= attribute: [xxxxx=out]
ERROR: Found wrongly attached attribute: [footprint=2]
ERROR: Found forbidden type= attribute: [type=out]
ERROR: Found misplaced pin attribute: [pintype=io]
@@ -8,5 +9,5 @@ ERROR: Found misplaced pin attribute: [pinlabel=not attached]
ERROR: Found misplaced pin attribute: [pinseq=3]
ERROR: Found misplaced pin attribute: [pinnumber=3]
ERROR: Found misplaced pin attribute: [pintype=io]
-1 warnings found
+2 warnings found
9 ERRORS found
diff --git a/gsymcheck/tests/old_symbol.output b/gsymcheck/tests/old_symbol.output
index 85e0318..b7f967c 100644
--- a/gsymcheck/tests/old_symbol.output
+++ b/gsymcheck/tests/old_symbol.output
@@ -1,3 +1,10 @@
+Warning: Found unknown slot1= attribute: [slot1=1,2,3]
+Warning: Found unknown slot2= attribute: [slot2=4,5,6]
+Warning: Found unknown slot3= attribute: [slot3=9,10,8]
+Warning: Found unknown slot4= attribute: [slot4=12,13,11]
+Warning: Found unknown pin3= attribute: [pin3=3]
+Warning: Found unknown pin2= attribute: [pin2=2]
+Warning: Found unknown pin1= attribute: [pin1=1]
Warning: Found obsolete uref= attribute: [uref=U?]
Warning: Missing pintype= attribute
Warning: Missing pintype= attribute
@@ -17,5 +24,5 @@ ERROR: Found old pin#=# attribute: pin1=1
ERROR: Found old slot#=# attribute: slot1=1,2,3
ERROR: Found old slot#=# attribute: slot2=4,5,6
ERROR: Found old slot#=# attribute: slot4=12,13,11
-5 warnings found
+12 warnings found
14 ERRORS found
diff --git a/gsymcheck/tests/oldpins.output b/gsymcheck/tests/oldpins.output
index fa0982a..1fa195b 100644
--- a/gsymcheck/tests/oldpins.output
+++ b/gsymcheck/tests/oldpins.output
@@ -1,3 +1,6 @@
+Warning: Found unknown pin3= attribute: [pin3=3]
+Warning: Found unknown pin2= attribute: [pin2=2]
+Warning: Found unknown pin1= attribute: [pin1=1]
ERROR: Missing pinseq= attribute
ERROR: Missing pinseq= attribute
ERROR: Missing pinseq= attribute
@@ -7,4 +10,5 @@ ERROR: Missing pinnumber= attribute
ERROR: Found old pin#=# attribute: pin3=3
ERROR: Found old pin#=# attribute: pin2=2
ERROR: Found old pin#=# attribute: pin1=1
+3 warnings found
9 ERRORS found
diff --git a/gsymcheck/tests/oldslot.output b/gsymcheck/tests/oldslot.output
index 4904107..09328bc 100644
--- a/gsymcheck/tests/oldslot.output
+++ b/gsymcheck/tests/oldslot.output
@@ -1,5 +1,10 @@
+Warning: Found unknown slot1= attribute: [slot1=1,2,3]
+Warning: Found unknown slot2= attribute: [slot2=4,5,6]
+Warning: Found unknown slot3= attribute: [slot3=9,10,8]
+Warning: Found unknown slot4= attribute: [slot4=12,13,11]
ERROR: Missing slotdef= (there should be 4 slotdef= attributes)
ERROR: Found old slot#=# attribute: slot1=1,2,3
ERROR: Found old slot#=# attribute: slot2=4,5,6
ERROR: Found old slot#=# attribute: slot4=12,13,11
+4 warnings found
4 ERRORS found
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs