Re: gEDA-user: [PATCH 1/2] gschem: line type edit dialog now uses GtkComboBox

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Fri, 2010-04-23 at 01:30 +0200, Krzysztof KoÅciuszkiewicz wrote:
> Previously used GtkOptionMenu is deprecated since GTK 2.4.
> Also eliminated TYPE_ERASE, unchanged line type is now communicated
> using a separate column in GtkTreeModel.
> ---

I've not reviewed the patch in minute detail, but this seems like
excellent work Krzysztof.  I'm really glad to see people taking an
interest in developing gEDA, and not just doing the shiny new bits which
add sexy new features, but helping with the necessary code maintenance.

I like the separate data-column for the "undetermined / unchanged"
value.  Note that "0" passed as the end-type column for that menu entry
will be the first enum type though, END_NONE. (Probably fitting I
guess).

I know I criticised adding a specific enum value for this kind of
meta-data, but I was still vaguely thinking that passing (say) -1, to
the type column would be how I'd do it. Your solution is cleaner ;)

Best wishes,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user