[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: [PATCH 1/2] gschem: line type edit dialog now uses GtkComboBox



On Fri, 2010-04-23 at 01:30 +0200, Krzysztof KoÅciuszkiewicz wrote:
> 
> +        case (TYPE_SOLID): 

Minor nit.. No new code tends to use the brackets here.. so since you
went to the bother of indenting the case(...) to case (...), you might
as well remove the brackets.

To be really nit picky - this kind of NOP change should really be a
separate patch so the more substantial changes can be reviewed easier.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user