[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: polygon regression in pcb+gl



On Wed, 2011-02-16 at 05:27 +0100, Kai-Martin Knaak wrote:

> The current head of his pcb+gl branch omits some polygons in my layouts. 
> See the attached screen shots. The working copy of pcb+gl was pulled from 
> repo.or.cz on December 6th. Unfortunately, I wasn't able to locate the 
> the exact version I pulled, or the commit that started the regression.

Urm - I think the bug got into git HEAD too. I think this commit has
caused a regression, but I'm not quite sure why.

commit 2d8dc8a3a3a55158b4e6278dd9f40588e4111c2d
Author: Ineiev <ineiev@xxxxxxxxxxxxxxxx>
Date:   Sun Dec 12 00:28:48 2010 -0500

    [PATCH] fix bug 2793480 (vias/arcs-to-polygon clearances)
    
    frac_circle(): introduce radius_adjustment factor to make
    the polygon outline the arc rather than connet points on the arc
    
    ArcPolyNoIntersect(): compute number of segments so that
    polygon diverges from the arc no more than 0.02 of
    required thickness; adjust outer "arc" radius like in frac_circle()


Any ideas why?

KMK - can you confirm that reverting this patch fixes the problem?
(Reverting polygon.c from my latest branch with a copy from the checkout
you have which works reveals the above commit is the major change... and
other edits don't seem to be a problem).

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)
Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)

Attachment: signature.asc
Description: This is a digitally signed message part


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user