Re: gEDA-user: Segfault in PS hid -> patch

[Hans Nieuwenhuis <vzzbx@xxxxxxxxx>]

On Thu, 11 Jan 2007 15:33:14 -0500
DJ Delorie <dj@xxxxxxxxxxx> wrote:

> 
> > -  fprintf (f, "showpage\n");
> > +  if (f)
> > +    fprintf (f, "showpage\n");
> 
> The right place to do this test is at the beginning of the function.
> There are a lot of other printfs in that function that you didn't fix,
> but one check at the beginning should cover them all.

I tried that, but then the multifile option stops working...

> 
> >  	  f = psopen (filename, layer_type_to_file_name (idx));
> > +	  if (!f)
> > +	  {
> > +	    perror(filename);
> > +	    return 0;
> > +	  }
> > +		  
> 
> We should use the Message() function so that the message pops up
> instead of just going to the console.
> 
Was thinking about that too, it is a bit more elegant to do. For now I just wanted to let it stop segfaulting.


Hans


-- 

$ cat .sig /dev/null


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user