Re: gEDA-user: PCB patches

[Jared Casper <jaredcasper@xxxxxxxxx>]

On Sun, Jun 7, 2009 at 7:59 PM, Steven Michalske<smichalske@xxxxxxxxx> wrote:
> On Jun 7, 2009, at 1:04 PM, DJ Delorie wrote:
>>> My mouse patch removed alt_pressed as it removed the only use of it
>>> (at the time).
>>
>> Ah.  Could you send me one patch that does what you want,
>> self-contained, then?
>>
> I'll take a look at the new mouse handling code from Jared and rebase
> my patches
>
> I'll need to wrap my head around the changes :-)
>

I think the changes you made should be orthogonal to the mouse.  If I
understood your patch correctly, you were just adding a
"mod1_is_pressed" function to the hid interface.

The conflict came because for the lesstif hid you were using the
variable alt_pressed to decide if mod1 was pressed, but that variable
was only being used in the mouse handling code (when a button was
pressed it would set alt_pressed based on the modifier mask from the
button press event, then use alt_pressed in the mouse handling thing),
it wasn't being used anywhere else (which is why my patch removed it).
 So even without my patch, with the code as it was, I don't think your
lesstif_mod1_is_pressed would have worked as anticipated.

I think the thing to do is probably add alt_pressed back in (in
parallel to shift_pressed, ctrl_pressed) and actually set it in the
mod_changed() function which is called on a key press event.  Then
your original patch should work as expected.

Jared


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user