Re: gEDA-user: pcb-20091103 for Gentoo, working on ebuild

[Stefan Salewski <mail@xxxxxxxxxxxx>]

On Sat, 2009-11-07 at 16:51 +0000, Peter Clifton wrote:
> On Sat, 2009-11-07 at 14:07 +0100, Stefan Salewski wrote:
> 
> > --docdir="/usr/share/doc/pcb-20091103"
> > seems to generate an obsolete empty directory
> > /usr/share/pcb-20091103/
> 
> That directory is somewhat of an annoyance on my box.. 
> 
I am not sure if I really understand your comment.
By default documentation goes into /usr/share/doc/pcb directory. For
gentoo convention is to have a subdirectory for each version, so we
have /usr/share/doc/pcb-20091103. Works fine with --docdir= but this
seems to generate the empty usr/share/pcb-20091103/ also.

> > For gentoo we like to have examples and tutorials in the doc
> > directories, so gentoo developers employ these patches:
> > #       sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in || die "sed failed"
> What is the purpose of the above?
> Does it stop the build of those dirs?
> 
> > #       sed -i -e 's/DOC=doc/DOC="doc example tutorial"/' configure || die "sed failed"
> What is the purpose of the above?
> 
> > #       sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in || die "sed failed"
> 
> Does this fix it so it installs in $docdir/example/
>                                    $docdir/tutorial/ etc..?

Yes, but I have to admit that I do not really understand these patches. 

> 
> IE. same as the other distros?
> 
> I'd support making that change, but I'm not sure what your other sed
> substitutions are for.
> 
> (Hacking Makefile.in is a pain to follow, since we just need to fix
> Makefile.am upstream, and it will almost certainly be a much more
> readable fix!)
> 

Personally I always do not like patches of Makefile.in too much, because
I do not understand it good enough to be sure that it does only good
things. Some Gentoo developers use mv commands (I would prefer this
myself), but Denis of sci-electronics area seems to like patches of
Makefile.in. (And I am sure he knows what he did.)

My gues is:
	sed -i -e 's/example//' -e 's/tutorial//' -e 's/ win32//' Makefile.in || die "sed failed"
	sed -i -e 's/DOC=doc/DOC="doc example tutorial"/' configure || die "sed failed"
	sed -i -e 's/$(pkgdatadir)/$(docdir)/' {example,tutorial}/Makefile.in || die "sed failed"


First line removes example and tutotial (and win32) directories
from /usr/share/pcb.

Second line generates  example and tutorial
in /usr/share/doc/pcb-20091103/

Third line fixes the empty usr/share/pcb-20091103/

Best regards

Stefan Salewski




_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user