Stefan Salewski <mail@xxxxxxxxxxxx> wrote: > autoroute.c:3431: warning: ‘add_clearance’ defined but not used > djopt.c:2461: warning: ‘nudge_corner’ defined but not used > draw.c:381: warning: passing argument 3 of ‘DrawSilk’ discards qualifiers from pointer target type > file.c:1129: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result > report.c:680: warning: no return statement in function returning non-void > rtree.c:203: warning: ‘__r_tree_is_good’ defined but not used > hid/common/actions.c:88: warning: passing argument 1 of ‘hid_register_actions_context’ discards qualifiers from pointer target type > hid/common/hidnogui.c:279: warning: ignoring return value of ‘scanf’, declared with attribute warn_unused_result > hid/common/hidnogui.c:303: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result > hid/common/hidnogui.c:321: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result > hid/gtk/gui-dialog.c:101: warning: format not a string literal and no format arguments > hid/gtk/gui-dialog.c:145: warning: format not a string literal and no format arguments > hid/gtk/gui-top-window.c:2512: warning: format not a string literal and no format arguments Very nice reports (see attachment). > hid/gtk/gui-dialog.c:172: warning: format not a string literal and no format arguments Should be like it is: the function semantics differ from the printf() ones. > flags.c:226: warning: cast from pointer to integer of different size OffsetOf() shall not overflow even 16 bits when MAX_LAYERS < 2048. > parse_l.l:198: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result > parse_l.c:1508: warning: ‘input’ defined but not used > res_lex.l:64: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result > res_lex.c:1139: warning: ‘input’ defined but not used Parser generator artifacts IMVHO. > /usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buffer > /usr/include/bits/string3.h:153: warning: call to __builtin___strncat_chk might overflow destination buffer No idea. > hid/common/actions.c:214: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result > hid/common/actions.c:215: warning: ignoring return value of ‘fwrite’, declared with attribute warn_unused_result If an error occurs while writing into stderr, probably the most useful reaction is to ignore it. > hid/png/png.c:313: warning: ‘save_flags.f’ may be used uninitialized in this function One of the least PNG exporter issues addressed by this branch: http://repo.or.cz/w/geda-pcb/dti.git/shortlog/refs/heads/kai-martin-scriptaction Thanks, Ineiev
Attachment:
0001-fix-some-warnings-suggested-by-Stefan-Salewski.patch
Description: Binary data
_______________________________________________ geda-user mailing list geda-user@xxxxxxxxxxxxxx http://www.seul.org/cgi-bin/mailman/listinfo/geda-user