[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: pcb crooked traces



On Sat, Oct 09, 2010 at 07:41:09PM -0400, DJ Delorie wrote:
> 
> I think we got it right the first time we discussed it way back when.
> We're just rehashing old arguments, no new info is being added.  I
> know what we're going to do, and we all seem to agree it's the right
> thing to do...
> 

I've sat down and started playing with this idea. Doing a simple
search-and-replace of the types `Dimension' and `BDimension' to
`Length' gets us this:

-bash@odadjian ~/Code/pcb-andrew$ git status
# On branch nanometers
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#
#       modified:   src/autoplace.c
#       modified:   src/autoroute.c
#       modified:   src/change.c
#       modified:   src/change.h
#       modified:   src/create.c
#       modified:   src/create.h
#       modified:   src/crosshair.c
#       modified:   src/draw.c
#       modified:   src/find.c
#       modified:   src/find.h
#       modified:   src/global.h
#       modified:   src/misc.c
#       modified:   src/mtspace.c
#       modified:   src/mtspace.h
#       modified:   src/parse_y.y
#       modified:   src/polygon.c
#       modified:   src/polygon.h
#       modified:   src/rotate.c
#       modified:   src/rubberband.c
#       modified:   src/search.c
#       modified:   src/search.h
#       modified:   src/set.c
#       modified:   src/set.h
#       modified:   src/thermal.c
#       modified:   src/undo.c
#

That gives us a vague idea of the scope of this project. Not as wide as
I thought, but still pretty wide. Also, there are two types of variables
that were originally set to `BDimension': distances and scale factors.

My thinking is, we should replace BDimension with two units:

1. length_t (long long) (or long, on 32-bit machines, if it turns out to
   matter) which is used to store lengths in base units.

2. scale_t (double) which is used to scale things for GUI zoom, very large
   or very small boards, etc. Most of these variables are already named
   `scale' so they should be easy to find.

Most of the oddball types we have (Dimension, BDimension, Cardinal,
Position, etc) should be consolidated into those two.


I'm just throwing ideas into the air. What do you guys think?


Andrew



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user