[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [Libevent-users] evutil_closesocket() macro portability.
- To: libevent-users@xxxxxxxxxxxxx
- Subject: Re: [Libevent-users] evutil_closesocket() macro portability.
- From: Nick Mathewson <nickm@xxxxxxxxxxxxx>
- Date: Wed, 14 Apr 2010 01:39:52 -0400
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: libevent-users-outgoing@xxxxxxxx
- Delivered-to: libevent-users@xxxxxxxx
- Delivery-date: Wed, 14 Apr 2010 01:40:06 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:received:message-id:subject :from:to:content-type:content-transfer-encoding; bh=Sen9dif5mkzNIed8HaV0MWY83e7SPTEV8d/uauibst4=; b=TZaJim7Pv0Td/kzlb4rkFoMjiMFTmFYbs740LhdZ/JOR2mPkO8T95CgGVDPv5nqhU6 DrEjNZP2x7Tnm5Zma4BewQ860SvhlaUhf9lGy+DZwF5kSUswEmzDD4tPo/Hvsh6862Jy uSqzVEWeZp972fwlWXNH3JKBgQ8n9u1KjEkq8=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=F69em1/BAHzqJuhScZg52kekL15ufH0/jX3cgAGoD26CFJB8Vc9Zo4kNXXfj6NEpEx Ab6nKYo/ngodMs69wpfoxHoZ8Am3grUBh3liP+62y6yr9dtW/TrQ/8y/iW6gcNn63l/L xCjDmRMbnXfiuc2zi1wvwiG4Bi12jCCMLCbp4=
- In-reply-to: <56FC1A2E-A658-44D3-9B81-8544BB6FFC6B@xxxxxxxx>
- References: <AcrLO8Igof9d2fdkSSKBjUV2d7rz/A==> <56FC1A2E-A658-44D3-9B81-8544BB6FFC6B@xxxxxxxx>
- Reply-to: libevent-users@xxxxxxxxxxxxx
- Sender: owner-libevent-users@xxxxxxxxxxxxx
On Wed, Mar 24, 2010 at 6:21 AM, Sebastian Sjöberg
<Sebastian.Sjoberg@xxxxxxxx> wrote:
> Hi,
>
> The EVUTIL_CLOSESOCKET() macro requires you to include unistd.h in your source for linux and I don't know what on windows. To ease portablilty wouldn't it be nice if we either turned the macro into a function or included the appropriate header where we define the macro?
>
> I'd be happy to provide a patch for whatever behavior you would prefer.
Sounds plausible. We might as well turn it into a function: an extra
function call is going to be cheap in comparison with the system call.
--
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users in the body.