Re: [Libevent-users] Patch: Propagate errors on SSL bufferevents

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Tue, Jul 26, 2011 at 4:37 AM, Joachim Bauch <jojo@xxxxxxxxxxx> wrote:
> Hi,
>
> SSL bufferevents that use another bev as underlying source don't
> propagate errors (like "connection closed") to the user. The
> attached patch fixes this.

Hm.  Certainly, dropping the error can't be the right answer here, so
I'm applying this patch to 2.0.

Looking further at that code, I wonder whether the "else if" chain is
right: those flags are not defined to be mutually exclusive, are they?

Also, I wonder if people will need to know the difference between an
error that occurred on the SSL bufferevent or on the underlying
bufferevent.  Perhaps we ought to add another flag to indicate whether
the error occurred at an underlying level or at the top level.  But
maybe folks can do without it?  Something to keep in mind for possible
future work.

-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.