[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [Libevent-users] Re: [PATCH]: libevent/dns DNS_ERR_NOANSWERS



On Wed, Aug 10, 2011 at 17:18, Mark Ellzey <mthomas@xxxxxxxxxx> wrote:
> On Wed, Aug 10, 2011 at 04:56:27PM +0400, Leonid Evdokimov wrote:
>> + Â Â Â Â Â Â } else if (reply && !reply->have_answer) {
>> + Â Â Â Â Â Â Â Â error = DNS_ERR_NOANSWER;
>> + Â Â Â Â Â Â } else {
>> + Â Â Â Â Â Â Â Â error = DNS_ERR_UNKNOWN;
>
> There is an odd edge-case in dns. DNS_ERR_NOANSWER isn't actually a
> great name.

I agree, can you suggest better name / err_to_string value? It can't
be DNS_ERR_NONE if we want to preserve compatibility with existing
evdns users who may be relying on current behavior.

The case is not rare nowadays: consider A and AAAA records instead of
TXT and A (that's exactly my use-case).
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.