[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [Libevent-users] off_t confusion

An autoconf setting (to use largefile or not) would be a great start, and I like the idea of defaulting to 64-bit, even though it will probably break some people who don't compile that way but use off_t in their code. From what I can tell, a 64-bit interface to the OS is more general, and then if you have to expose legacy 32-bit stubs to keep existing code from breaking, that might be ok? (Hopefully you don't have to go the fopen64() route to stay compatible.)

Looks like off_t only affects libevent's addfile/sendfile and DNS?


On 8/15/2011 8:42 AM, Nick Mathewson wrote:
On Thu, Aug 11, 2011 at 2:06 PM, Michael Herf<herf@xxxxxxxxx>  wrote:
I'm compiling libevent on Solaris.
ev_off_t appears to be #define'd as off_t on UNIX machines ("#define
ev_off_t off_t" in util.h).
However, on this machine, off_t is first defined in *stdio.h*!
Additionally, my app uses the following defines to make stdio 64-bit aware:
Of course, libevent does *not* compile with these flags, and so off_t is 32
bits when the library is built, and then it's 64 bits in my app!
This makes for all sorts of fun when calling evbuffer_add_file.
I suspect other OSes have a consistent off_t and so this case isn't insane.
But *why* is ev_off_t based on stdio in this case (is this a Solaris
My patch for now is to use "always be 64-bit" for ev_off_t (like the Windows
code does). Any other suggestions to make this more bulletproof?
  i.e. #define ev_off_t ev_int64_t
Here's what I think makes the most sense here: we should first off
invoke the magic flags while building libevent that use largefile
stuff wherever possible internally.  This is disgustingly nonportable,
but not _so_ bad in practice.  In libevent 2.0, we can do so by adding
stuff to CFLAGS or adding appropriate defines to util-internal.h and
making sure that we pull it in everywhere.  In libevent 2.1, we should
use the new evconfig-private.h mechanism for autoconf-based
definitions that only want to apply during the library build.

But for our headers, we should just do something like

#define ev_off_t ev_int64_t
#define ev_off_t ev_int32_t

This is a possible fix IMO for 2.1.  I'm not sure weether doing it for
2.0 is API/ABI safe.

To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.