[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [Libevent-users] [PATCH] Add Host header in HTTP/1.1 requests if it's missing.

To: libevent-users@xxxxxxxxxxxxx
Subject: Re: [Libevent-users] [PATCH] Add Host header in HTTP/1.1 requests if it's missing.
From: Nick Mathewson <nickm@xxxxxxxxxxxxx>
Date: Fri, 19 Aug 2011 11:20:52 -0400
Delivered-to: archiver@xxxxxxxx
Delivered-to: libevent-users-outgoing@xxxxxxxx
Delivered-to: libevent-users@xxxxxxxx
Delivery-date: Fri, 19 Aug 2011 11:21:02 -0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=uPLMVqvgcgx7Bz+9pkD1XOMneBdwoQPnnhvNAPfgDoE=; b=S6sw/flPg4+twaE3cQCqMmt5qEC8p+m3GPVROw/1OaFBgTS4SD4vSgbjYlgq/u2Lnr C6S+F7fmzCWUj1a08SttzgI0wqy2UROGb0zndGTFH7rkY+WGWmrV4VPUT1O9GC4cyaGb yrygqdLP/4ew1nm80L1F4K18MUbVg6qCreC58=
In-reply-to: <CAB-U=tAc3Msx-5G0N0j-bz8pbzZTZU+jg2wE2SyVtx6w7Prb0A@xxxxxxxxxxxxxx>
References: <CAB-U=tAc3Msx-5G0N0j-bz8pbzZTZU+jg2wE2SyVtx6w7Prb0A@xxxxxxxxxxxxxx>
Reply-to: libevent-users@xxxxxxxxxxxxx
Sender: owner-libevent-users@xxxxxxxxxxxxx

On Fri, Aug 19, 2011 at 7:14 AM, Leonid Evdokimov <leon@xxxxxxxxxxxx> wrote:
> Hello,
>
> Here is patch to add "host" header to outgoing HTTP/1.1 requests.
> Please, review.
>
> Without the patch libevent-based evhttp-client.c can't get reply from
> any sane server because the request is rejected with "400 Bad request"
> and workaround - adding the header manually - is required.
>

Looks to me as if this should be using the REQ_VERSION_ATLEAST macro.

Other than that, it looks okay.  It'd need some tweaking for https
support, I think, where 443 is the default.  Perhaps the port should
be included unconditionally, if that doesn't break anything: the rfc
says that we _can_ omit port 80, not that we must.

-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.

References:
- [Libevent-users] [PATCH] Add Host header in HTTP/1.1 requests if it's missing.
  - From: Leonid Evdokimov

Prev by Author: Re: [Libevent-users] sendfile on solaris
Next by Author: Re: [Libevent-users] Possible to use libevent to handle SIGTERM and SIGQUIT
Previous by thread: Re: [Libevent-users] [PATCH] Add Host header in HTTP/1.1 requests if it's missing.
Next by thread: Re: [Libevent-users] [PATCH] Add Host header in HTTP/1.1 requests if it's missing.
Index(es):
- Author
- Thread