Re: [Libevent-users] Signals and priority queues

[Ralph Castain <rhc@xxxxxxxxxxxx>]

On Jan 13, 2012, at 12:56 PM, Nick Mathewson wrote:

> On Fri, Jan 13, 2012 at 2:52 PM, Ralph Castain <rhc@xxxxxxxxxxxx> wrote:
>> 
>> Hah! I see what happened. I removed it because it was marked as an OMPI change:
>> 
>> -               /****    OMPI CHANGE    ****/
>> -               /* set a timeval to avoid blocking select on Windows */
>> -#ifndef WIN32
>> -               *tv_p = NULL;
>> -#else
>> -               struct timeval now = {1, 0};
>> -               **tv_p = now;
>> -#endif
>> -               /****  END OMPI CHANGE  ****/
>> 
>> 
>> In fact, the OMPI change is only the correction for Windows, which doesn't like a NULL timeval pointer. I'll restore that and make the comment clearer, then test and get back to you.
>> 
>> Did you absorb all the Windows changes we sent you (believe this was one, but there are others)? Or do you want them again?
>> 
> 
> I have no idea.  Can you send a link to where you sent them?

Scanning thru, it looks like pretty much everything beyond configuration stuff made it. IIRC, we put the patches on your bug tracker per your request at the time (it has been awhile though, so my memory is faint). Only thing missing (other than the above) is in include/event2/buffer.h:

struct evbuffer_iovec {
/****    OMPI CHANGE    ****/
/* Added windows check */
#ifndef __WINDOWS__
	/** The start of the extent of memory. */
	void *iov_base;
	/** The length of the extent of memory. */
	size_t iov_len;
#else
	WSABUF data;
#endif
/****  END OMPI CHANGE  ****/
};

In fairness, I have no idea how much testing this change has seen. Just noting its existence.

>  I don't
> think I would have merged a "forever is secretly one second" patch.

Guess it depends on application - one second is a very long time, in our world :-) I'm not a Windows person, but I can refer you to the folks who did it, if you like, as I'm sure they had a reason. 

> 
> yrs,
> -- 
> Nick
> ***********************************************************************
> To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
> unsubscribe libevent-users    in the body.

***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.