Re: [Libevent-users] using libEvent 2.x with Visual C++

[Patrick Pelletier <ppelletier@xxxxxxxxxx>]

On 06/08/2012 09:18 PM, Patrick Pelletier wrote:

> I've also taken it a bit further, and added support for OpenSSL to
> Makefile.nmake. Unfortunately, I don't know nmake very well (I haven't
> yet looked up how to do conditionals, for example), so my Makefile.nmake
> is very hacked up right now and not suitable for general use. But if
> anyone wants to peek at it, in its current ugly state, it's on my
> "windows-ssl" branch on github at git://github.com/ppelleti/libevent.git

I've cleaned up my windows-ssl branch, so it now uses conditionals 
properly.  By default, Makefile.nmake builds without OpenSSL, as before. 
 But if you uncomment the line:

# OPENSSL_DIR=c:\openssl

and set it to wherever you installed OpenSSL, then Makefile.nmake will 
build with OpenSSL support.  I'm not sure if there's a better way to do 
this conditional; I know next to nothing about nmake.  But it seemed 
reasonable enough.  (Suggestions for improvement are definitely welcome, 
though.)

What is the preferred way to submit this as a merge request?  Should I 
submit a pull request in github, or mail out the result of "git 
format-patch", or is the following good enough?

The following changes since commit e7bf4c84afd7961eb92a2d6583c84b56a87f2555:

  Make the Makefile.nmake warning slightly less dire (2012-06-08 
16:50:25 -0400)

are available in the git repository at:

  git@xxxxxxxxxx:ppelleti/libevent.git windows-ssl

for you to fetch changes up to eba0eb2e71a975517b88099cf1f925e1712fe03a:

  attempt to support OpenSSL in Makefile.nmake (2012-07-03 22:50:24 -0700)

----------------------------------------------------------------
Patrick Pelletier (1):
      attempt to support OpenSSL in Makefile.nmake

 Makefile.nmake      |   34 ++++++++++++++++++++++++++++++----
 test/Makefile.nmake |   17 ++++++++++++++---
 2 files changed, 44 insertions(+), 7 deletions(-)

--Patrick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.