[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [Libevent-users] SSL problems after update to libeven 2.1.8
- To: libevent-users@xxxxxxxxxxxxx
- Subject: Re: [Libevent-users] SSL problems after update to libeven 2.1.8
- From: Till Toenshoff <till@xxxxxxxxxxxxx>
- Date: Wed, 3 Oct 2018 03:32:57 +0200
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: libevent-users-outgoing@xxxxxxxx
- Delivered-to: libevent-users@xxxxxxxx
- Delivery-date: Tue, 02 Oct 2018 21:33:03 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mesosphere.io; s=google; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=lpXoHw5uNMoInzaw3Ct4+yY7gI9X5NiX4L7CmHFAUEs=; b=C1GbmzPpiJ1f6NeIhtrvtB3j+vQ2+3VYiEVeaj55clXZKlGCZUiv+n5yXbBWToegTk th3TFyaJIzHLZnqEJxGrZM8hCoyPFawpz/BMPCk4WhHYtvP/KNLCacSXbjKAyFKbG6Kt ETxB2KnBLIoDguyt3GzIdsApzgNAu0EcLPoMk=
- In-reply-to: <20181002215404.4nv243lmachlyi3u@carbon.azat.localdomain>
- References: <7549CDE3-675F-4EC0-8D7E-051ED2FCEB63@mesosphere.io> <20180909231314.jeeunh6q3jcauaqf@carbon.azat.localdomain> <04EC0810-99DC-4FB5-9335-230F132FC5EC@mesosphere.io> <F9C52CF1-1F73-42B9-829A-67A95A4AB9F6@mesosphere.io> <20180910100222.hbga3e3ete4fq7vd@carbon.azat.localdomain> <85F8645F-6176-4A09-9A0A-E49F32963E00@mesosphere.io> <20180930215205.rjhn3eulodgev4vl@macbook-pro.sq.azat.localdomain> <61760B94-46F0-456E-B766-07DE14F2EB33@mesosphere.io> <20181002215404.4nv243lmachlyi3u@carbon.azat.localdomain>
- Reply-to: libevent-users@xxxxxxxxxxxxx
- Sender: owner-libevent-users@xxxxxxxxxxxxx
> Also it contains some fixes for cmake (since I don't like autotools due
> to how difficult to handle every single dependency right there, in
> particular "make -C 3rdparty/libprocess/ -j4 libprocess-tests" will not
> built all dependencies, if you curious).
That part I have yet to look into but I believe that we are still incomplete on our CMake adoption - specifically for building our own libprocess without building the entire Mesos project. Will pick up on that soonish.
> Thanks but this contribution guide requires too much actions for this
> small patches, so I would rather prefer the second option.
sgtm - got a patch series up now; see https://reviews.apache.org/r/68906/
Note that I moved the setup of EV_READ | EV_WRITE setup a bit further up on the connect part. I was worried that without doing so, we could possibly run into races caused by data being available early. This would be matching our callback setup timing. Please let me know if that was not in line with best practices on the use of libevent.
>
>>> Also since you wrote that "reverting makes thing worse" could you verify referenced patches (including osx) ?
>>
>> Am doing that right now. Getting back to you later today.
>>
>> Thanks so much again, I am dancing in circles right now, that is how much this issue bothered me.
>
> Great! Let's see if he issue will gone! (obvious it should)
I can confirm it works as expected in the following combinations;
macOS 10.14.1 - libevent 2.2
macOS 10.14.1 - libevent 2.1.8
macOS 10.14.1 - libevent 2.0.22
Ubuntu 16.04 - libevent 2.1.8
You nailed it! :)
Thanks again!
Till***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users in the body.