[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28622 [Applications/Tor Browser]: Update Tor Browser Icon for Android
#28622: Update Tor Browser Icon for Android
-------------------------------------------------+-------------------------
Reporter: pili | Owner: tbb-
| team
Type: task | Status:
| needs_information
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: ux-team, tbb-mobile, TBA-a3, tbb- | Actual Points:
parity, tbb-8.5-must-alpha, |
TorBrowserTeam201904R, GeorgKoppen201904 |
Parent ID: #27399 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):
* status: needs_review => needs_information
Comment:
300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build bug_28622_v2)
- Seems ok
f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
{{{
-ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
+ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
}}}
I'm guessing this isn't an important change.
I'll assume all of the binary changes are okay.
{{{
--- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd
+++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd
@@ -2,8 +2,8 @@
- License, v. 2.0. If a copy of the MPL was not distributed with this
- file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
-<!ENTITY brandShortName "Tor Browser">
-<!ENTITY brandFullName "Tor Browser for Android">
-<!ENTITY vendorShortName "The Tor Project">
+<!ENTITY brandShortName "Nightly">
+<!ENTITY brandFullName "Mozilla Nightly">
+<!ENTITY vendorShortName "Mozilla">
}}}
This doesn't seems like the result we want, right? Similarly, I'm guessing
`mobile/android/branding/alpha/locales/en-US/brand.properties` was copied
from `mobile/android/branding/nightly`, should that use the same content
as the old torbrowser file?
{{{
--- a/mobile/android/branding/torbrowser/locales/en-US/brand.properties
+++ /dev/null
@@ -1,7 +0,0 @@
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-
-#filter
-brandShortName=Tor Browser
-brandFullName=Tor Browser for Android
}}}
{{{
--- /dev/null
+++ b/mobile/android/branding/alpha/locales/en-US/brand.properties
@@ -0,0 +1,6 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+brandShortName=Nightly
+brandFullName=Mozilla Nightly
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28622#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs