Re: [tor-bugs] #28622 [Applications/Tor Browser]: Update Tor Browser Icon for Android

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#28622: Update Tor Browser Icon for Android
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-mobile, TBA-a3, tbb-    |  Actual Points:
  parity, tbb-8.5-must-alpha,                    |
  TorBrowserTeam201904R, GeorgKoppen201904       |
Parent ID:  #27399                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_information => needs_review


Comment:

 Replying to [comment:30 sysrqb]:
 > 300c55e5e0cf8e24f49959eababd2c7d9fc056ad (tor-browser-build
 bug_28622_v2) - Seems ok
 >
 > f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
 >
 > {{{
 > -ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 >  MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
 > +ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 > }}}
 >
 > I'm guessing this isn't an important change.

 No, it's just aligning that file with the layout of the other
 `configure.sh` files (those for stable and nightly).

 > I'll assume all of the binary changes are okay.
 >
 > {{{
 > --- a/mobile/android/branding/torbrowser/locales/en-US/brand.dtd
 > +++ b/mobile/android/branding/alpha/locales/en-US/brand.dtd
 > @@ -2,8 +2,8 @@
 >     - License, v. 2.0. If a copy of the MPL was not distributed with
 this
 >     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
 >
 > -<!ENTITY  brandShortName  "Tor Browser">
 > -<!ENTITY  brandFullName   "Tor Browser for Android">
 > -<!ENTITY  vendorShortName "The Tor Project">
 > +<!ENTITY  brandShortName  "Nightly">
 > +<!ENTITY  brandFullName   "Mozilla Nightly">
 > +<!ENTITY  vendorShortName "Mozilla">
 > }}}
 >
 > This doesn't seems like the result we want, right? Similarly, I'm
 guessing `mobile/android/branding/alpha/locales/en-US/brand.properties`
 was copied from `mobile/android/branding/nightly`, should that use the
 same content as the old torbrowser file?

 Huh, you are right. I am not sure how this happened, sorry for that. I
 pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the
 same branch that should correct this for all supported series, that is
 stable (aka official), alpha, and nightly. I am following here the desktop
 lead and don't differentiate the brand names based on series but using the
 same for all three.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28622#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs