Re: [tor-bugs] #9663 [Tor]: Table-based basepoint multiply optimizations for ntor handshake

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9663: Table-based basepoint multiply optimizations for ntor handshake
-----------------------------+----------------------------------------
     Reporter:  nickm        |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay performance ntor
Actual Points:               |  Parent ID:  #9662
       Points:               |
-----------------------------+----------------------------------------

Comment (by andrea):

 Code review follows for the ticket8897_9663_v2 branch:

 ee5afe07090f1ae163e7d8bac5e62b233106f319:
  - Good lord that's a lot of hairy code; since it's all external I'll
 presume it okay for now.

 c2eeeae1cf88085f24edd7f01364e8734924b14d:
  - This looks fine to me.

 4961107f90cf7d6eb5258a48c47a4fd009dbe5a5:
  - This looks fine to me.

 eec326b05d043da1d81e5ac8f7231e83e08a8d1e:
  - This looks fine to me presuming the constants were derived by using a
 known-good
    implementation.

 dc8534dadfe87f762c072bc7d1bbf37326a676f0:
  - This looks fine to me.

 34ff6bd40f29a7df6346b2c2bb49ce42141afb5a:
  - This looks fine to me.

 82175b53276f2be4a63d940ba224c87890128548:
  - This looks fine to me.

 77dd3fd5017b9331b1a265419145b62fd1a5298c:
  - This looks okay but perhaps in the interest of paranoia we should also
 spot-check
    the fallback?

 b0c9c55d6dece98030aed99f076a7223bb0f5e64:
  - This looks fine to me.

 c4ae4850efc46c04e7409e119aff16e327227a38:
  - It strikes me as grossly counterintuitive that it is possible for
 OPTIONAL_INLINE
    to expand to a thing containing __attribute__((always_inline)).
  - Otherwise, this seems fine.

 f4e9ecae2b0239f2c16c18808114842092b5007d:
  - I repeat my remarks about ee5afe07090f1ae163e7d8bac5e62b233106f319 for
 this.

 298cfa90555feb01aebac71419f67aa8467d9bcc:
  - This looks good to me.

 79337975c2f9b0ea045b48666c523294624c2558:
  - This looks good to me.

 4b463e20f0b1939764a09eaa74b380ec282daf81:
  - This looks good to me.

 4147cb2d4dc33c51c91fd2d6275af0b4773b738d:
  - This looks good to me.

 812674f4971e8f843322e81e20f2638f525e875e:
  - This looks good to me.

 88b0f91a0107b0988b52d09d8ec7c9c8180ed669:
  - This looks good to me.

 86a239f7f392fc4d6f52e3e671a9f2a8808359e5:
  - This looks good to me.

 0284e22e7b37a0ce8fc0fc1f27fd2af768768af3:
  - This looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9663#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs