[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #9663 [Tor]: Table-based basepoint multiply optimizations for ntor handshake
#9663: Table-based basepoint multiply optimizations for ntor handshake
-----------------------------+----------------------------------------
Reporter: nickm | Owner:
Type: enhancement | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.5.x-final
Component: Tor | Version:
Resolution: | Keywords: tor-relay performance ntor
Actual Points: | Parent ID: #9662
Points: |
-----------------------------+----------------------------------------
Comment (by nickm):
Replying to [comment:4 andrea]:
> Code review follows for the ticket8897_9663_v2 branch:
>
> ee5afe07090f1ae163e7d8bac5e62b233106f319:
> - Good lord that's a lot of hairy code; since it's all external I'll
presume it okay for now.
Actually I've gotten cold feet; I'm going to make it off-by-default for
now.
> 77dd3fd5017b9331b1a265419145b62fd1a5298c:
> - This looks okay but perhaps in the interest of paranoia we should
also spot-check
> the fallback?
Okay, will do.
> f4e9ecae2b0239f2c16c18808114842092b5007d:
> - I repeat my remarks about ee5afe07090f1ae163e7d8bac5e62b233106f319
for this.
This one I'm going to leave on-by-default, since none of its potential
inputs are hostile.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9663#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs