[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20596 [Metrics]: streamline build.xml and metrics_checkstyle.xml throughout all java projects

#20596: streamline build.xml and metrics_checkstyle.xml throughout all java
projects
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  iwakeh
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by karsten):

 I merged your commits to the official metrics-base repository.

 The latest branches I'm working with are:

  - https://gitweb.torproject.org/metrics-base.git/log/ (78c6249)
  -
 https://gitweb.torproject.org/user/iwakeh/onionoo.git/log/?h=task-20596-submod
 (df833f8)
  - https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-20596 (f08713b)
  - https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-20596
 (5578881)

 Remaining issues are:

  - Neither CollecTor's `*-sources.jar` file nor its `*-javadoc.jar` file
 should contain the two files `collector.properties` and `logback.xml`.
 Can you remove those (but leave them in the main `*.jar`)?

  - Onionoo's `.war` file still contains manifest entry `Created-By: The
 Tor Project` which I guess should also be `Implemented-By: The Tor
 Project` as in the `.jar` file.

  - There should be change log entries in all three code bases on medium or
 minor level saying something like: "Replaced several build files or parts
 thereof with their equivalents from the metrics-base repository to unify
 the build process among metrics code bases."  Feel free to tweak that
 sentence.  I can add it while merging.

 We're getting closer! :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:40>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs