Re: [tor-bugs] #20596 [Metrics]: streamline build.xml and metrics_checkstyle.xml throughout all java projects

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#20596: streamline build.xml and metrics_checkstyle.xml throughout all java
projects
-------------------------+------------------------------
 Reporter:  iwakeh       |          Owner:  iwakeh
     Type:  enhancement  |         Status:  needs_review
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+------------------------------

Comment (by iwakeh):

 Replying to [comment:40 karsten]:
 > I merged your commits to the official metrics-base repository.
 >
 > The latest branches I'm working with are:
 >
 >  - https://gitweb.torproject.org/metrics-base.git/log/ (78c6249)
 >  -
 https://gitweb.torproject.org/user/iwakeh/onionoo.git/log/?h=task-20596-submod
 (df833f8)
 >  - https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-20596 (f08713b)
 >  - https://gitweb.torproject.org/karsten/metrics-
 db.git/log/?h=task-20596 (5578881)

 I just noticed that you use your own branches for collector and metrics-
 lib and assume there were no changes I should have looked at.

 >
 > Remaining issues are:
 >
 >  - Neither CollecTor's `*-sources.jar` file nor its `*-javadoc.jar` file
 should contain the two files `collector.properties` and `logback.xml`.
 Can you remove those (but leave them in the main `*.jar`)?

 Fixed in metrics-base.

 >
 >  - Onionoo's `.war` file still contains manifest entry `Created-By: The
 Tor Project` which I guess should also be `Implemented-By: The Tor
 Project` as in the `.jar` file.

 Fixed in Onionoo.

 >
 >  - There should be change log entries in all three code bases on medium
 or minor level saying something like: "Replaced several build files or
 parts thereof with their equivalents from the metrics-base repository to
 unify the build process among metrics code bases."  Feel free to tweak
 that sentence.  I can add it while merging.

 Added changelog entries to onionoo, collector, descriptor ;-)

 All changes on the known branches in my git repos.

 >
 > We're getting closer! :)

 Yes!  This all might seem tedious, but while making the fixes it is
 already very much more efficient; and, I guess trying to keep all projects
 in sync without metrics-base would just cause exponentially more
 iterations if not being an impossible task in the long run.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs