[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21047 [Metrics/Onionoo]: atlas plotting bandwidth use from 2019

#21047: atlas plotting bandwidth use from 2019
-----------------------------+------------------------------
 Reporter:  arma             |          Owner:  metrics-team
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-help     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by iwakeh):

 Looks fine and has a shiny new test!

 I removed a checkstyle complaint from the test and changed it to use test
 data with a future date computed from the current time instead of having
 another dependency on Time and TimeFactory class. (Long ago we discussed
 that these are problematic and by reducing using them they might be
 obsolete at some point. Maybe, Time and TimeFactory should even be
 deprecated?)

 Please find the patch
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git/commit/?h=task-21047-2&id=d28bec1a23cfb45283a7e5edf157b5f39c3edb15
 here].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21047#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs