Re: [tor-bugs] #21047 [Metrics/Onionoo]: atlas plotting bandwidth use from 2019

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21047: atlas plotting bandwidth use from 2019
-----------------------------+--------------------------------
 Reporter:  arma             |          Owner:  metrics-team
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-help     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for reviewing, and thanks for catching that checkstyle complaint!

 However, there's a problem with the amended test: as time progresses, the
 four sample lines will be merged into a single data point in a "3_months"
 graph, and that graph won't be written anymore, because we require at
 least two consecutive data points in a graph.  tl;dr: we'll have to
 calculate dates for the first four lines as well, ideally by picking
 yesterday or the day before.  Should we do that and keep the `Time`
 dependency out, or should we just keep the test unchanged and only fix the
 checkstyle issue?  I don't feel strongly.

 Oh, one more thing to fix: `status.setFromDocumentString(documentString);`
 needs to stay, or the test won't succeed.

 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21047#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs