Re: [tor-bugs] #16801 [Core Tor/Tor]: Increase torgzip coverage as high as possible

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16801: Increase torgzip coverage as high as possible
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  testing, 028-triage, tor-tests-      |        Version:
  coverage, tor-tests-unit TorCoreTeam201606     |     Resolution:
Parent ID:  #17289                               |  Actual Points:  .2
 Reviewer:  nick                                 |         Points:  1
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by cypherpunks):

 Commit cdb8f57a3138f6f9a59183094e89ee72df43d356

 {{{
 +#if defined ZLIB_VERNUM && ZLIB_VERNUM < 0x1200
 +#define "We require zlib version 1.2 or later."
 +#endif
 }}}
 Shouldn't this be `#error`? And if so, wouldn't it be better to test this
 when setting up the build environment (aka `./configure`)?

 {{{
 -  if (is_gzip_supported()) {
 +
 +  if (1) {
 }}}
 Why not simply remove the if statement?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16801#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs