[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16801 [Core Tor/Tor]: Increase torgzip coverage as high as possible

#16801: Increase torgzip coverage as high as possible
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
 Priority:  Medium                               |  needs_review
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  testing, 028-triage, tor-tests-      |        Version:
  coverage, tor-tests-unit TorCoreTeam201606     |     Resolution:
Parent ID:  #17289                               |  Actual Points:  .2
 Reviewer:  nick                                 |         Points:  1
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 > Shouldn't this be #error?
 yup, #error.

 We could check it in configure (if somebody wants to write a patch) but
 personally I don't expect that there are enough zlib 1.1 users remaining
 for this to be worth much time.

 >Why not simply remove the if statement?

 IMO best to do that as a separate patch, so that the diff doesn't get
 spuriously large.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16801#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs