[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #26251 [Applications/Tor Browser]: Adapt macOS snowflake compilation to new toolchain



#26251: Adapt macOS snowflake compilation to new toolchain
--------------------------------------+-----------------------------------
 Reporter:  gk                        |          Owner:  tbb-team, sukhbir
     Type:  task                      |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------

Comment (by sukhbir):

 Replying to [comment:5 gk]:
 > Before I forget it: we should make sure snowflake is working on macOS <
 10.11. IIRC there was a note somewhere in the snowflake build patch
 indicating that the SDK version used is at the same time the minimum macOS
 version supported. But that's not the case for us: we use the 10.11 SDK
 but want to have Tor Browser running on, say, 10.9 as well.

 Good point and I think dcf or arlolra can comment better, but two things I
 did not change for this reason:

 {{{
 print("machine_os_build=\"10.7\"")
 }}}

 and

 {{{
 GN_ARGS+=" target_os=\"mac\" target_cpu=\"x64\"
 mac_deployment_target=\"10.7\""
 }}}

 But I tested it on 10.11 so I am not sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26251#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs