[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #26251 [Applications/Tor Browser]: Adapt macOS snowflake compilation to new toolchain
#26251: Adapt macOS snowflake compilation to new toolchain
--------------------------------------+-----------------------------------
Reporter: gk | Owner: tbb-team, sukhbir
Type: task | Status: needs_revision
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+-----------------------------------
Changes (by gk):
* status: needs_review => needs_revision
Comment:
Replying to [comment:4 sukhbir]:
> Please review:
>
> https://github.com/azadi/tor-browser-build-1/tree/bug-26251
>
> I have not properly patched `build/config/mac/BUILD.gn` in `webrtc-
mac.patch` as you may notice and just added the `-Wno-unknown-warning-
option` manually. I can do that in `rev2` or before finalizing the patch,
but I wanted to put it out for review before I deal with `gclient`.
Does not look unreasonable `-mlinker-version=136` and probably other flags
are not needed anymore. You could compare the macOS mozconfig file used on
the `maint-7.5` and on the `master` branch for the diff. Then I am looking
forward to the full patch with `gclient` etc.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26251#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs