Re: [tor-bugs] #4795 [Firefox Patch Issues]: TBB does not like the standard theme on Windows XP, Vista, and 7

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#4795: TBB does not like the standard theme on Windows XP, Vista, and 7
-------------------------------------+--------------------------------------
    Reporter:  runa                  |       Owner:  mikeperry
        Type:  defect                |      Status:  assigned 
    Priority:  major                 |   Milestone:           
   Component:  Firefox Patch Issues  |     Version:           
  Resolution:                        |    Keywords:           
      Parent:                        |      Points:           
Actualpoints:                        |  
-------------------------------------+--------------------------------------

Comment(by Shondoit):

 Replying to [comment:37 mikeperry]:
 > Since this isn't a direct or indirect violation of our privacy and
 security requirements, I think it's not 'major' for us. This means we'll
 need help if we ever want to get this fixed.
 arma changed this to major because of the high rate of mentions (see
 comment 33.) Also, because it's been a bug for months I suggest keeping
 this as major. My two cents.

 > I think one could actually call the lack of maximize button a feature
 due to the fingerprinting issues when doing that, though I agree lack of
 minimize and close is annoying.
 The buttons are only invisible. It still works when clicking in the middle
 of the black bar.
 As well as the other options to maximize (right click title bar +
 maximize, win7: drag against top, alt + space + x) this is hardly a
 'feature'.

 > 1. Which parts of the CSS patch actually make a difference?
 This is an interesting one. The patch comments out an entire block of
 //Mozilla extensions, but this section contains things like
 '_moz_windows_default_theme', '_moz_windows_compositor' and
 '_moz_windows_theme'. I reckon a combination of these removed features is
 responsible for the black control box and the transparency issues. It will
 take some time to figure out which ones.
 Check out nsMediaFeatures.cpp, line 459 and down. I'm not sure removing
 this block of features was the best course of action. I recommend
 rereading the source and revising this choice if needed.

 > 2. Why does the browser chrome give a shit about media features that are
 supposed to be for HTML content?
 Because this is not only for HTML content but rather for chrome in
 general? Because Firefox supports theming and uses these features for
 compositing?
 I have no idea and this question is better asked in Mozilla channels.

 > 3. Is the patch responsible even for the menu transparency issues too,
 or just the titlebar buttons?
 Yes, it's responsible for the menu transparency issues too.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4795#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs