[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4795 [Firefox Patch Issues]: TBB does not like the standard theme on Windows XP, Vista, and 7

#4795: TBB does not like the standard theme on Windows XP, Vista, and 7
-------------------------------------+--------------------------------------
    Reporter:  runa                  |       Owner:  mikeperry        
        Type:  defect                |      Status:  needs_information
    Priority:  major                 |   Milestone:                   
   Component:  Firefox Patch Issues  |     Version:                   
  Resolution:                        |    Keywords:                   
      Parent:                        |      Points:                   
Actualpoints:                        |  
-------------------------------------+--------------------------------------
Changes (by mikeperry):

  * status:  assigned => needs_information


Comment:

 Replying to [comment:42 Shondoit]:
 > Replying to [comment:37 mikeperry]:
 > > Since this isn't a direct or indirect violation of our privacy and
 security requirements, I think it's not 'major' for us. This means we'll
 need help if we ever want to get this fixed.
 > arma changed this to major because of the high rate of mentions (see
 comment 33.) Also, because it's been a bug for months I suggest keeping
 this as major. My two cents.

 Fine. I'm just trying to find a rational way to define ticket priorities.
 I was questioned earlier when "seems important, probably should get done"
 was my previous metric.

 > > 1. Which parts of the CSS patch actually make a difference?
 > This is an interesting one. The patch comments out an entire block of
 //Mozilla extensions, but this section contains things like
 '_moz_windows_default_theme', '_moz_windows_compositor' and
 '_moz_windows_theme'. I reckon a combination of these removed features is
 responsible for the black control box and the transparency issues. It will
 take some time to figure out which ones.
 >
 > Check out nsMediaFeatures.cpp, line 459 and down. I'm not sure removing
 this block of features was the best course of action. I recommend
 rereading the source and revising this choice if needed.

 Yeah, word. It probably will require a few compiles on Windows to binary
 search it down to the exact rules that actually matter, or a few hours of
 wading through source. Though starting with uncommenting just the
 _moz_windows stuff and the blocks with min/maximize in it seems like a
 good guess to start.

 If someone who can actually compile our beast on Windows can narrow it
 down, it might help me to more easily hazard a guess.

 Setting this to "needs information" to reflect the fact that answers to
 these questions will help me fix it faster.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4795#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs