Re: [tor-bugs] #9069 [Flashproxy]: Set have_websocket_binary_frames for Firefox

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9069: Set have_websocket_binary_frames for Firefox
----------------------------+-------------------------------
     Reporter:  dcf         |      Owner:  dcf
         Type:  defect      |     Status:  needs_information
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:  easy
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+-------------------------------

Comment (by dcf):

 Replying to [comment:5 arlolra]:
 > Replying to [comment:4 dcf]:
 >
 > > Can you explain this diff?
 > > {{{
 > > -    if (ua === null)
 > > +    if (ua == null)
 > > }}}
 >
 > Double equals null is shorthand for,
 > {{{
 >  if ( ua === null || ua === undefined )
 > }}}

 Right, I understand that. But I try to avoid semi-mysterious behavior like
 that. The flashproxy source code doesn't use double-equals anywhere for
 that reason. I think after I read that Douglas Crockford recommended never
 to use double-equals, and it made sense to me, so I started doing it.

 The change seems unrelated to the rest of the patch. Is it a bug that we
 are not currently checking against `undefined`? In what environments is it
 the case? If so, we should fix and document it separately.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9069#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs