Re: [tor-bugs] #9069 [Flashproxy]: Set have_websocket_binary_frames for Firefox

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#9069: Set have_websocket_binary_frames for Firefox
----------------------------+-------------------------------
     Reporter:  dcf         |      Owner:  dcf
         Type:  defect      |     Status:  needs_information
     Priority:  normal      |  Milestone:
    Component:  Flashproxy  |    Version:
   Resolution:              |   Keywords:  easy
Actual Points:              |  Parent ID:
       Points:              |
----------------------------+-------------------------------

Comment (by arlolra):

 Replying to [comment:7 dcf]:

 > The change seems unrelated to the rest of the patch. Is it a bug that we
 are not currently checking against `undefined`? I mean, what caused you to
 make the change, were your tests failing or something? If so, we should
 fix and document it separately. If we have to fix it here, there are
 probably other places we have to fix it.

 The reason it came up is because in the test I added a case,
 {{{
 { expected: false },  // no userAgent
 }}}
 which sets `ua` to `undefined`.

 This is a problem because later `ua` is assumed to be a string,
 {{{
 ua.match( ... )
 }}}

 Maybe the best thing would be to do,
 {{{
 typeof ua !== "string"
 }}}

 There looks to another problem in `flashproxy_should_disable()`. If `ua`
 is `null` there, it skips the first if block and blows up. I can supply a
 patch for these if you want.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9069#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs