[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24175 [Metrics/Website]: Use an embedded Jetty in metrics-web and use metrics-base as build environment.

#24175: Use an embedded Jetty in metrics-web and use metrics-base as build
environment.
-----------------------------+--------------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Wow, that's a commit with three thousand, six hundred twenty-six lines.

 Let's try to split that commit into five or ten or twenty commits to make
 the review at least somewhat more plausible.

 I can help (next week, though, not this week)! I've split numerous commits
 in the past. The four Onionoo tickets around versions and recommended
 versions started out as a single commit which I then split up into four.
 It facilitates reviews a lot, and in this case I'd even say that it
 ''enables'' reviews.

 Some ideas:

  - Let's start with changes to everything that gets the website running
 and switch to the data-processing modules after that.

  - We could even make changes to the various web-related parts step by
 step. For example, we could have one commit for updating the Rserve part
 and another one for producing the WAR file. Or maybe even more, I haven't
 looked.

  - The module changes can happen module by module, too.

  - Small changes that are unrelated to the overall change should come as
 separate commits. Some very quick suggestions for changes that could be
 separate commits:
    - Remove outdated HACKING file.
    - Take out that IOException in RelayDescriptorDatabaseImporter.
    - Remove unused imports from CollectorDirectoryProvider.
    - Update StrSubstitutor from Apache Lang to Lang3.
    - Handle null value in RObjectGenerator.
    - Remove unused imports from DirectoryListingTest. Possibly combined
 with the other removal of unused imports.

 Oh, and regarding the open topics, let's try to handle them prior to
 merging. What data can I provide?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24175#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs