[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #24175 [Metrics/Website]: Use an embedded Jetty in metrics-web and use metrics-base as build environment.
#24175: Use an embedded Jetty in metrics-web and use metrics-base as build
environment.
-----------------------------+--------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Website | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-----------------------------+--------------------------------
Comment (by iwakeh):
Replying to [comment:3 karsten]:
> Wow, that's a commit with three thousand, six hundred twenty-six lines.
Well, that is a little overstating it as there are many moved folders,
which
won't be reviewed file by file or line by line ;-)
> ...
> Let's try to split that commit into five or ten or twenty commits to
make the review at least somewhat more plausible. ...
I really didn't want to have half baked commits, with two build
environments around etc. that causes trouble without need (btw the web
part doesn't really deviate much from ExoneraTor).
It shouldn't be a problem to review a moved package tree.
But of course, I see your point and will try to come up with a few more
commits.
> Oh, and regarding the open topics, let's try to handle them prior to
merging. What data can I provide?
I clearly stated above (naming it the first round) that I didn't intend to
suggest any merge!
Data might help, true. Just wait with providing anything, as I might
define a clearer set of data needed or make it work in this round.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24175#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs