[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27356 [Metrics/ExoneraTor]: Reduce database size and variance of query response times

#27356: Reduce database size and variance of query response times
--------------------------------+--------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_revision
 Priority:  High                |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  irl                 |        Sponsor:
--------------------------------+--------------------------------
Changes (by irl):

 * status:  needs_review => needs_revision


Comment:

 I've checked it over for any obvious errors and the tests pass, but I
 notice that none of the tests actually use the database.

 I'm having difficulty reviewing these as there are many squash commits
 with lots of commit messages, but I haven't been following from the start.
 Could you rebase this on another branch with a single commit containing
 the changes (or just provide the commit message here in the ticket) so
 that I can understand a) what the changes are meant to be and b) the
 motivation/intent behind those changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27356#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs