Re: [tor-bugs] #27356 [Metrics/ExoneraTor]: Reduce database size and variance of query response times

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#27356: Reduce database size and variance of query response times
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  metrics-team
     Type:  enhancement         |         Status:  needs_review
 Priority:  High                |      Milestone:
Component:  Metrics/ExoneraTor  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  irl                 |        Sponsor:
--------------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:8 irl]:
 > I've checked it over for any obvious errors and the tests pass, but I
 notice that none of the tests actually use the database.

 That's true. Having more useful tests in ExoneraTor is, unfortunately, a
 little project of its own. We already have #24365 for this, but it's not
 as high priority as it could/should be. Let's try to leave room for these
 things in the next roadmap.

 > I'm having difficulty reviewing these as there are many squash commits
 with lots of commit messages, but I haven't been following from the start.
 Could you rebase this on another branch with a single commit containing
 the changes (or just provide the commit message here in the ticket) so
 that I can understand a) what the changes are meant to be and b) the
 motivation/intent behind those changes.

 It's a single commit, 8159855, with a couple squash commits. I'd rather
 not rebase in the middle of the review, as I wouldn't do that for any
 upcoming changes coming out of this review. I'll rebase before merging,
 though, but until then, can you check out this branch and run `git diff
 da3eb1f` (parent of 8159855) to see all changes together? The commit
 message of 8159855 explains what the changes are all about.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27356#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs